Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths for windows dev server #836

Open
pi0 opened this issue Jan 13, 2023 · 1 comment
Open

Normalize paths for windows dev server #836

pi0 opened this issue Jan 13, 2023 · 1 comment
Labels
bug Something isn't working windows

Comments

@pi0
Copy link
Member

pi0 commented Jan 13, 2023

Linked issues:

They were fixed by #732 and #733 but since fixes introduced new issues (#808), reverting on 2.x edge until finding a new solution.

@pi0 pi0 added bug Something isn't working windows labels Jan 13, 2023
@pi0
Copy link
Member Author

pi0 commented Jan 13, 2023

From linked issues, a common problem was, externals.inline is not being effective. inlined runtime dir by nuxt-turnstile using node's fileURLToPath has backslash and not matching fixed by 0638f64 and nuxt-security not including it at all (Baroshem/nuxt-security#84)

In addition, Nuxt has to automatically add transpile[] to externals.inline[] i belive for best DX. (we need downstream issue @danielroe )

Also while most of the cases with plugins and middleware need to be inlined, it seems there is still an strange behavior by rollup that even when returning {id: 'file://...', external: true} from resolver it trims it out from final bundle. I will try to investigate this more but probably better if we have a pure nitro reproduction first for this. It might be also a case with unimport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

No branches or pull requests

1 participant