Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use file urls for auto-imports in development #733

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt-modules/turnstile#85

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Similar to #732, we should use file urls in dev mode for absolute auto-import paths. I'll rebase this once that merges, but thought I'd open this first so you're aware.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 6, 2022
@danielroe danielroe requested a review from pi0 December 6, 2022 13:23
@danielroe danielroe self-assigned this Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #733 (e1a5caf) into main (f08708d) will decrease coverage by 0.06%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   66.91%   66.85%   -0.07%     
==========================================
  Files          57       57              
  Lines        4232     4242      +10     
  Branches      460      460              
==========================================
+ Hits         2832     2836       +4     
- Misses       1397     1403       +6     
  Partials        3        3              
Impacted Files Coverage Ξ”
src/options.ts 85.66% <36.36%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: use file urls for auto-imports fix: use file urls for auto-imports in development Dec 6, 2022
@pi0 pi0 merged commit d04554a into main Dec 6, 2022
@pi0 pi0 deleted the fix/auto-import-urls branch December 6, 2022 14:29
@danielroe danielroe mentioned this pull request Dec 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants