Fixed mobile phone validation for pt-br #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 95
Lines ? 1248
Branches ? 0
==========================================
Hits ? 1248
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
|
Tanks bro |
profnandaa
reviewed
Sep 20, 2020
| @@ -5174,12 +5174,14 @@ describe('Validators', () => { | |||
| { | |||
| locale: 'pt-BR', | |||
| valid: [ | |||
| '+55-12-996551215', | |||
There was a problem hiding this comment.
Could you please explain this regression?
There was a problem hiding this comment.
Brazilian numbers never use dashes between numbers.
lunatupini
approved these changes
Oct 20, 2020
| @@ -5174,12 +5174,14 @@ describe('Validators', () => { | |||
| { | |||
| locale: 'pt-BR', | |||
| valid: [ | |||
| '+55-12-996551215', | |||
There was a problem hiding this comment.
Brazilian numbers never use dashes between numbers.
profnandaa
approved these changes
Oct 21, 2020
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed RegExp for pt-br phone number validation, now supporting new numbers that start with 9 and are followed by 2, 3 or 4 (3 and 4 are more common, but 2 is also possible)