Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release staging: Nov 2020 release notes #1535

Merged
merged 2 commits into from
Nov 30, 2020
Merged

release staging: Nov 2020 release notes #1535

merged 2 commits into from
Nov 30, 2020

Conversation

profnandaa
Copy link
Member

@profnandaa profnandaa commented Nov 29, 2020

13.5.0 - November 2020 Release

@profnandaa
Copy link
Member Author

@tux-tn @ezkemboi -- please review and I will land today evening.

@profnandaa profnandaa changed the title Nov 2020 release notes release staging: Nov 2020 release notes Nov 29, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #1535 (4ddba07) into master (0f8e597) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1535   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8e597...4ddba07. Read the comment docs.

Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks accurate and good.
It seems we are missing #1534.
Also, I am not sure if we need to include #1513?

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
Just a little question, the version number shouldn't be 13.2.0 instead of 13.5.0 ?

@dkochetkov
Copy link
Contributor

@profnandaa please check link in this row (now is 1468):

#1467 RU @dkochetkov

@profnandaa
Copy link
Member Author

Thank you for the review folks.

@ezkemboi @dkochetkov -- good catches, updating.
@tux-tn -- we are jumping 4 steps up since we introduced 4 new features, so each feature gets a minor version bump. However, I'm not certain on what we should do for locale updates, for now I take them as "fixes", so if it wasn't for the minor v bump, we could have moved a number of patch bumps up. // semver MAJOR.MINOR.PATCH

@profnandaa
Copy link
Member Author

It's now live on NPM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants