Fix gradle build and clean issue on Windows. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
============================================
- Coverage 59.19% 58.28% -0.91%
Complexity 31 31
============================================
Files 2 2
Lines 174 175 +1
Branches 22 22
============================================
- Hits 103 102 -1
- Misses 68 70 +2
Partials 3 3
Continue to review full report at Codecov.
|
vanniktech
reviewed
Sep 1, 2017
|
Yeah, you are right. It fixed problem but wasn't generating reports properly. In second commit I moved file creation to doFirst{} block, this way problem is also fixed, all reports are working and most importantly files will be created only during gradle execution phase, and not as before – on configuration phase. |
|
I'm at the conference at the moment and will look soon. |
vanniktech
requested changes
Sep 6, 2017
| ignoreExitValue = true | ||
|
|
||
| doFirst { | ||
| new File(outputDirectory).mkdirs() | ||
| standardOutput = new FileOutputStream("$outputFile") |
There was a problem hiding this comment.
can be just new FileOutputStream(outputFile)
| @@ -244,13 +244,16 @@ class CodeQualityToolsPlugin implements Plugin<Project> { | |||
|
|
|||
| subProject.task('ktlint', type: Exec) { | |||
| commandLine 'java', '-cp', subProject.configurations.ktlint.join(System.getProperty('path.separator')), 'com.github.shyiko.ktlint.Main', '--reporter=checkstyle', 'src/**/*.kt' | |||
| def outputDirectory = new File(subProject.buildDir, "reports/ktlint/") | |||
| outputDirectory.mkdirs() | |||
| def outputDirectory = "${subProject.buildDir}/reports/ktlint" | |||
| def outputDirectory = new File(subProject.buildDir, "reports/ktlint/") | ||
| outputDirectory.mkdirs() | ||
| def outputDirectory = "${subProject.buildDir}/reports/ktlint" | ||
| def outputFile = "$outputDirectory/ktlint-checkstyle-report.xml" |
|
Done |
vanniktech
reviewed
Sep 6, 2017
| @@ -244,13 +244,16 @@ class CodeQualityToolsPlugin implements Plugin<Project> { | |||
|
|
|||
| subProject.task('ktlint', type: Exec) { | |||
| commandLine 'java', '-cp', subProject.configurations.ktlint.join(System.getProperty('path.separator')), 'com.github.shyiko.ktlint.Main', '--reporter=checkstyle', 'src/**/*.kt' | |||
| def outputDirectory = new File(subProject.buildDir, "reports/ktlint/") | |||
| outputDirectory.mkdirs() | |||
| def outputDirectory = "${subProject.buildDir}reports/ktlint" | |||
- ktlint: create report filed during execution phase
vanniktech
approved these changes
Sep 6, 2017
|
Sorry it took so long. Thanks for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am facing the following issue on my windows machine: after building the project I am unable to clean it because windows refuses to delete ktlint checkstyle report.
https://gist.github.com/anonymous/6e2b55fe13ab806880faf0fc0dd70cba
It seems that this file is being locked by plugin code.
In my fix I deleted FileOutputStream that seems to be unnecessary.
I verified it on my machine.