Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths in ktlint output directory 2.0 #87

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Fix paths in ktlint output directory 2.0 #87

merged 1 commit into from
Sep 12, 2017

Conversation

AndrewPolovko
Copy link
Contributor

I am sorry that I didn’t check my last revision of previous pull request (#84) on windows.
(It takes about 10 minutes to check it on my project)
When we removed “/” in outputDirectory and outputFile paths it created following issues:

  1. Ktlint reports are created in folder buildreports instead of build\reports\ktlint. And buildreports folder has empty folder ktlint.
  2. Reports has name: “ktlintktlint-checkstyle-report”
  3. It is not possible to delete or open report file
    Returning back those 2 slashes in outputDirectory and outputFile fixes all problems above.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will yield to a double slash. // Does not it?

@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     58.28%   58.28%           
  Complexity       31       31           
=========================================
  Files             2        2           
  Lines           175      175           
  Branches         22       22           
=========================================
  Hits            102      102           
  Misses           70       70           
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...h/code/quality/tools/CodeQualityToolsPlugin.groovy 57.3% <100%> (ø) 31 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e8632...e0c0eda. Read the comment docs.

@AndrewPolovko
Copy link
Contributor Author

I can't speak for linux but on windows it works just fine.
I assume that slash at the end of outputDirectory is just ignored because i get the same result with and without slash at the end.

@AndrewPolovko
Copy link
Contributor Author

AndrewPolovko commented Sep 12, 2017

I removed slash at the end of outputDirectory since it is redundant.

@vanniktech vanniktech merged commit b36208f into vanniktech:master Sep 12, 2017
@artem-bagritsevich
Copy link

Hi @vanniktech, could you please release 0.9.0? We need this changes for our project.

@vanniktech
Copy link
Owner

I'll do so. For now you can take the SNAPSHOT. I'll probably get to it on the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants