update readme #100
Merged
update readme #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrielittner
commented
Jan 30, 2020
gabrielittner
commented
- tries to go through the steps in the right order
- mention all properties we support
- mention Sonatype OSS more explicitly
- make signing more prominent
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage 36.21% 36.21%
Complexity 48 48
=========================================
Files 21 21
Lines 417 417
Branches 67 67
=========================================
Hits 151 151
Misses 241 241
Partials 25 25Continue to review full report at Codecov.
|
anggrayudi
approved these changes
Jan 30, 2020
vanniktech
approved these changes
Jan 31, 2020
|
|
||
| ***Uploading:*** | ||
| The username and password for Sonatype OSS can be provided as Gradle properties or environment |
There was a problem hiding this comment.
Let's mention which properties need to be set here for Gradle
There was a problem hiding this comment.
Do you mean something other than SONATYPE_NEXUS_USERNAME and SONATYPE_NEXUS_PASSWORD which are mentioned in the next line?
There was a problem hiding this comment.
Oh right they're both sharing the same name. Then never mind
Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.