Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new signing property outside of targets #101

Merged
merged 3 commits into from
Jan 31, 2020
Merged

new signing property outside of targets #101

merged 3 commits into from
Jan 31, 2020

Conversation

gabrielittner
Copy link
Collaborator

The property on signing doesn't really make sense. For maven-publish it was never used and for the old plugin the implementation was kind of hacky by checking which the upload task was going to be executed. This replaces the old property with a single one that is used for all targets. It defaults to a gradle property so you could still dynamically change it when running certain upload tasks.

I will update the readme after both this and #100 were merged

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #101 into master will decrease coverage by 0.35%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #101      +/-   ##
===========================================
- Coverage     36.76%   36.4%   -0.36%     
  Complexity       49      49              
===========================================
  Files            21      21              
  Lines           408     412       +4     
  Branches         68      68              
===========================================
  Hits            150     150              
- Misses          230     234       +4     
  Partials         28      28
Impacted Files Coverage Δ Complexity Δ
...vanniktech/maven/publish/BaseMavenPublishPlugin.kt 62.16% <0%> (ø) 4 <0> (ø) ⬇️
...vanniktech/maven/publish/MavenPublishConfigurer.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420a258...9fcdeb5. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants