-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accented characters being displayed twice in 607/608 stream #6427
Closed
5 tasks done
mamaddox opened this issue
May 21, 2024
· 0 comments
· Fixed by #6439, anime-vsub/app#107, anime-vsub/app#108 or Tisankan/bemusic-spotify_clone#22 · May be fixed by anime-vsub/app#109
Closed
5 tasks done
Accented characters being displayed twice in 607/608 stream #6427
mamaddox opened this issue
May 21, 2024
· 0 comments
· Fixed by #6439, anime-vsub/app#107, anime-vsub/app#108 or Tisankan/bemusic-spotify_clone#22 · May be fixed by anime-vsub/app#109
Comments
mamaddox
added
Bug
Needs Triage
If there is a suspected stream issue, apply this label to triage if it is something we should fix.
labels
May 21, 2024
robwalch
added
Confirmed
and removed
Needs Triage
If there is a suspected stream issue, apply this label to triage if it is something we should fix.
labels
May 21, 2024
robwalch
added a commit
that referenced
this issue
May 23, 2024
3 tasks
robwalch
added a commit
that referenced
this issue
May 31, 2024
* patch/v1.5.x: Update github actions chore(deps): update tjenkinson/gh-action-auto-merge-dependency-updates action to v1.4.2 (#6333) Emit FRAG_PARSING_ERROR on unsupported M2TS codec (#6447) Fix JS AES fallback when browserCrypto.subtle returns undefined (rather than null) (#6446) Fix 608 caption TextTrack Cue seek/discontinuity timing regression introduced in v1.5.0 with #5557 Fix 608 parser handling of redundant control codes Fixes #6427 Fix backtracking when an appended segment has no buffered timerange (#6434) Fix missing details if subtitle changed synchronously after loaded and before onLoaded callback (#6424) Bugfix: Handle irregular white-space in segment URIs (#6396)
agajassi
added a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
ported changes from video-dev/hls.js#6427
agajassi
added a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
ported changes from video-dev/hls.js#6427
2 tasks
agajassi
added a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
ported changes from video-dev/hls.js#6427 Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com>
agajassi
added a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
ported changes from video-dev/hls.js#6427 Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com>
littlespex
pushed a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
* Create extractCea608DataFromSample.ts * Create seiHelpers.ts * Update extractCea608DataFromSample.ts * Update seiHelpers.ts * Update getCharForByte.ts * ported changes from video-dev/hls.js#6427 * Create SccParser.ts * Update Cta608Parser.ts --------- Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com>
littlespex
pushed a commit
to streaming-video-technology-alliance/common-media-library
that referenced
this issue
Jun 5, 2024
* Create extractCea608DataFromSample.ts * Create seiHelpers.ts * Update extractCea608DataFromSample.ts * Update seiHelpers.ts * Update getCharForByte.ts * ported changes from video-dev/hls.js#6427 * Create SccParser.ts * Update Cta608Parser.ts --------- Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Hls.js are you using?
1.4.10 (But tested on 1.5.8 as well)
What browser (including version) are you using?
Chrome 124.0.6367.62
What OS (including version) are you using?
macOS 12.7.2
Test stream
https://cpac-vod.cdn.vustreams.com/cpac/vod/b69d4bce-1c39-4fb4-9b1e-ad016553bb8b/b69d4bce-1c39-4fb4-9b1e-ad016553bb8b_nodrm_3a7ee1c0-beb8-41eb-8623-d00096e3de23.ism/.m3u8
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
Expected behaviour
Accented characters should be displayed only once
What actually happened?
Certain accented characters are displaying twice
Did a little investigation in the cea-608-parser.ts, and it looks like characters 0x80-0x8f are the special characters that are being duplicated:
hls.js/src/utils/cea-608-parser.ts
Lines 59 to 74 in d97009e
Not sure if it's related to the
insertChar
function.hls.js/src/utils/cea-608-parser.ts
Lines 448 to 470 in d97009e
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: