Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtracking when an appended segment has no buffered timerange #6434

Merged
merged 1 commit into from
May 23, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Clear backtracking fragments stuck in "APPENDING" state without reducing max buffer length.

Why is this Pull Request needed?

Reducing the max buffer length and skipping fragment tracker removal is done to address BUFFER_FULL errors (#5354).

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6428

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.9 milestone May 22, 2024
@robwalch robwalch merged commit ee3abcd into master May 23, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/backtracking-not-appended branch May 23, 2024 23:16
robwalch added a commit that referenced this pull request May 23, 2024
robwalch added a commit that referenced this pull request May 31, 2024
* patch/v1.5.x:
  Update github actions
  chore(deps): update tjenkinson/gh-action-auto-merge-dependency-updates action to v1.4.2 (#6333)
  Emit FRAG_PARSING_ERROR on unsupported M2TS codec (#6447)
  Fix JS AES fallback when browserCrypto.subtle returns undefined (rather than null) (#6446)
  Fix 608 caption TextTrack Cue seek/discontinuity timing regression introduced in v1.5.0 with #5557
  Fix 608 parser handling of redundant control codes Fixes #6427
  Fix backtracking when an appended segment has no buffered timerange (#6434)
  Fix missing details if subtitle changed synchronously after loaded and before onLoaded callback (#6424)
  Bugfix: Handle irregular white-space in segment URIs (#6396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxMaxBufferLength is getting lower than the fragment duration
1 participant