Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AC-3 codec in MPEG-TS #5167

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

erankor
Copy link
Collaborator

@erankor erankor commented Jan 17, 2023

This PR will...

Add support for AC-3 codec in MPEG-TS

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@erankor erankor force-pushed the support-ac-3 branch 6 times, most recently from cc40fab to c243119 Compare January 17, 2023 07:47
@erankor erankor mentioned this pull request Jan 17, 2023
5 tasks
@erankor
Copy link
Collaborator Author

erankor commented Jan 17, 2023

@robwalch, I applied the changes from #1102 on latest master + fixed the CI comments (looks like the CI has advanced significantly since I opened the original pull :))
I didn't change "type supported" to work lazily, IMHO it makes sense to do it for all formats, not just AC-3, and then it should probably be in a separate PR.

@erankor
Copy link
Collaborator Author

erankor commented Jan 17, 2023

One more thing, I looked again at this code now (it's been a few years since i wrote it...) and this looks wrong to me -
const frameDuration = (1536 / sampleRate) * 1000;
I think it should be 90000 instead of 1000, don't really remember why I used 1000... Maybe when I initially opened the PR, the tsdemuxer converted the 90kHz timestamps to millis?

@robwalch robwalch added this to the 1.5.0 milestone Jan 18, 2023
@robwalch
Copy link
Collaborator

One more thing, I looked again at this code now (it's been a few years since i wrote it...) and this looks wrong to me -
const frameDuration = (1536 / sampleRate) * 1000;
I think it should be 90000 instead of 1000, don't really remember why I used 1000... Maybe when I initially opened the PR, the tsdemuxer converted the 90kHz timestamps to millis?

I'll look into it for v1.5.0. Thank you for updating the PR.

@robwalch robwalch changed the title add support for ac-3 codec Add support for AC-3 codec in MPEG-TS Jan 18, 2023
@ccr-hls-crufter
Copy link

Hi @erankor And first of all, thanks for your work on this. I have build out your commits and have a few comments:

These are the two issues I have found playing around for a day with this. Again, thanks.

@fegauthier
Copy link
Contributor

Hi @erankor !

Thanks for your awesome work! I have some stream that has audio E-AC3 (0x87) which seems to be Dolby Digital Plus. Do you know if the parsing is the same as AC-3? If not, do you know if it's complex to implement it?

Thanks!

@robwalch robwalch merged commit fe6f333 into video-dev:master Jun 1, 2023
robwalch added a commit that referenced this pull request Jun 13, 2023
robwalch added a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants