Add AC3 file support and exclude AC3 parsing from hls.light builds #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robwalch Do you have a sample stream to test it? Thanks! |
|
@avelad, see the comment linked in the description. |
|
Thanks @robwalch ! |
robwalch
force-pushed
the
feature/ac3-file-exclude-from-light-build
branch
from
069a3fa
to
c9a7511
Compare
Merged
|
cc #253 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
With #5167 bringing support for parsing AC3 in M2TS, support for unwrapped AC3 segments is also needed so that support checks can be trusted regardless of container type.
This is a follow up from this comment and sample #1102 (comment), which aligns AC3 with AAC/ADTS and MP3 handling.
This also brings AC3 support inline with Safari.
Are there any points in the code the reviewer needs to double check?
In the light build, with AC3 probing disabled, the MP3 probe passes for some AC3 content. Not too concerned about this, but it does prevent the player from going down the desired error path. I don't have a solution for making the existing MP3 probing less prone to false positives.
Resolves issues:
Follow up to #5167
Checklist