Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task_2_3_1 #24

Merged
merged 9 commits into from
Jun 8, 2024
Merged

task_2_3_1 #24

merged 9 commits into from
Jun 8, 2024

Conversation

vlasival
Copy link
Owner

No description provided.

Copy link

File Coverage [0%]
Food.java 0%
Snake.java 0%
Element.java 0%
SnakeGame.java 0%
Total Project Coverage 0%

Copy link
Collaborator

@galinabykova galinabykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хорошо, что у тебя не смешивается представление с бизнес-логикой (по крайней мере я не заметила) ). Нужно добавить тестик и ещё написать мне, какой паттерн использовал. Ещё надо бы добавить fxml, чтобы ты потыкал его

Copy link

github-actions bot commented May 5, 2024

File Coverage [0%]
Snake.java 0%
Food.java 0%
Element.java 0%
SnakeGame.java 0%
Total Project Coverage 0%

Copy link

github-actions bot commented May 8, 2024

File Coverage [49.93%]
Food.java 100% 🍏
Element.java 100% 🍏
Snake.java 99.08% 🍏
GameModel.java 85.71% 🍏
SnakeGame.java 0%
SceneController.java 0%
MenuView.java 0%
ChangeSceneManager.java 0%
SceneType.java 0%
GameView.java 0%
Total Project Coverage 49.93%

@vlasival vlasival requested a review from galinabykova May 8, 2024 17:14
@vlasival
Copy link
Owner Author

vlasival commented May 8, 2024

Добавил FXML два окна: менюшка с выбором сложности игры и сама игра. Планировал ещё использовать свои текстуры и сохранение конфига игры в json, но не успел(

Copy link
Collaborator

@galinabykova galinabykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ты проделал большую работу, молодец) всё хорошо разделено, по коду замечаний нет, поправь ещё ревью дог

task_2_3_1/app/src/main/java/org/snake/viewmodel/View.java Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 9, 2024

File Coverage [48.45%]
Food.java 100% 🍏
Element.java 100% 🍏
Snake.java 95.85% 🍏
GameModel.java 85.71% 🍏
SnakeGame.java 0%
SceneController.java 0%
MenuView.java 0%
ChangeSceneManager.java 0%
SceneType.java 0%
GameView.java 0%
Total Project Coverage 48.45%

@vlasival vlasival requested a review from galinabykova May 9, 2024 04:09
Copy link

github-actions bot commented Jun 7, 2024

File Coverage [54.59%]
Food.java 100% 🍏
Direction.java 100% 🍏
Element.java 100% 🍏
Snake.java 99.1% 🍏
GameModel.java 82.07% 🍏
Intelligence.java 58.49%
SceneType.java 0%
ChangeSceneManager.java 0%
SceneController.java 0%
MyLogger.java 0%
SnakeGame.java 0%
GameView.java 0%
MenuView.java 0%
Total Project Coverage 54.59%

Copy link

github-actions bot commented Jun 7, 2024

File Coverage [52.97%]
Food.java 100% 🍏
Element.java 100% 🍏
Snake.java 97.74% 🍏
Direction.java 76.47%
GameModel.java 71.59%
Intelligence.java 59.87%
MyLogger.java 29.17%
SceneType.java 0%
ChangeSceneManager.java 0%
SceneController.java 0%
SnakeGame.java 0%
GameView.java 0%
MenuView.java 0%
Total Project Coverage 52.97%

Copy link

github-actions bot commented Jun 7, 2024

File Coverage [51.94%]
Food.java 100% 🍏
Element.java 100% 🍏
Snake.java 97.74% 🍏
Direction.java 76.47%
GameModel.java 71.59%
Intelligence.java 55.73%
MyLogger.java 29.17%
SceneType.java 0%
ChangeSceneManager.java 0%
SceneController.java 0%
SnakeGame.java 0%
GameView.java 0%
MenuView.java 0%
Total Project Coverage 51.94%

Copy link

github-actions bot commented Jun 7, 2024

File Coverage [51.94%]
Food.java 100% 🍏
Element.java 100% 🍏
Snake.java 97.74% 🍏
Direction.java 76.47%
GameModel.java 71.59%
Intelligence.java 55.73%
MyLogger.java 29.17%
SceneType.java 0%
ChangeSceneManager.java 0%
SceneController.java 0%
SnakeGame.java 0%
GameView.java 0%
MenuView.java 0%
Total Project Coverage 51.94%

@vlasival vlasival merged commit 475d939 into main Jun 8, 2024
2 checks passed
@vlasival vlasival deleted the task_2_3_1 branch June 8, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants