Add ability to add nginx conditionals #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really love to see this merged. Need this for some deployments of Gallery3 which needs it. |
|
@bashtoni can you please rebase? |
| @@ -32,5 +32,10 @@ | |||
| <% if @location_custom_cfg_append -%><% @location_custom_cfg_append.each do |value| -%> | |||
| <%= value %> | |||
| <% end -%><% end -%> | |||
|
|
|||
| <% @location_conditions.each do |condition| -%> | |||
There was a problem hiding this comment.
note: after you rebase, this should go in the templates/vhost/location_header.erb file.
|
after looking this over a bit more, I noticed it was missing a few things:
I've created another PR (#364) that adds raw_prepend/raw_append to vhosts and locations (in addition to a bit of spec cleanup). It is meant as a very generic (hence raw) prepend/append directive and would likely solve the same problems this PR does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows conditionals to be added to nginx vhost templates.
Our specific use case for this is to set the HTTPS environment variable for SSL connections offloaded to the load balancer.