new raw_prepend / raw_append feature for vhosts & locations #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added raw_prepend / raw_append to vhosts & locations, which
adds raw lines to the vhost/location /without/ semicolons
- added location_raw_prepend / location_raw_append to vhost
for passing through to default location
- added spec tests for new parameters
- cleaned up location specs to match new header/body/footer setup
reducing duplicate checks by testing header/footer separately.
- cleaned up whitespace (2 space) in touched files
- used `<%-` in erb templates to allow the use of leading
whitespace, making the logic flow more readable
- Also adds spec tests for recent vhost updates:
- client_body_timeout
- client_header_timeout
- gzip_types
- testing that the first server_name is used when www_to_non_www is true
|
@jfryman P.s., If you'd prefer, I can strip out the extra, non-related, spec tests into a separate PR - I just figured I'd add them while I was already working on the files. |
|
WFM. 🤘 |
jfryman
pushed a commit
that referenced
this pull request
Jun 27, 2014
new raw_prepend / raw_append feature for vhosts & locations
|
@jfryman Can these be pushed into Forge? I was looking at the location.pp hasn't been updated on forge since March for 0.0.9 push and there have been lots of changes since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds raw lines to the vhost/location /without/ semicolons
for passing through to default location
reducing duplicate checks by testing header/footer separately.
<%-in erb templates to allow the use of leadingwhitespace, making the logic flow more readable
note: this essentially takes care of conditionals as mentioned in #267