fix(no-deprecated-slot-attribute): handle v-for with dynamic slot #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
commented
Aug 15, 2024
| const vForText = vFor ? `${sourceCode.getText(vFor)} ` : '' | ||
| if (vFor) { | ||
| yield fixer.remove(vFor) | ||
| } |
There was a problem hiding this comment.
I also considered the case for v-if—would an empty template still cause the parent to think it received an empty slot?
But I confirmed in Vue 2 that these are identical in terms of the parent's this.$slots:
<Parent>
<div v-if="false" slot="name">
slot value
</div>
<template slot="name">
<div v-if="false">
slot value
</div>
</template>
</Parent>
privatenumber
commented
Aug 15, 2024
| const slotName = sourceCode.getText(slotAttr.value.expression).trim() | ||
| // If non-Latin characters are included it can not be converted. | ||
| // It does not check the space only because `a>b?c:d` should be rejected. | ||
| return !/[^a-z]/i.test(slotName) |
There was a problem hiding this comment.
I was confused about why it's doing this.
I felt like we just want to confirm it's a single Identifier so I went ahead and changed it and it didn't seem to break any tests, but I'm happy to revert this if we want to keep the scope small.
privatenumber
force-pushed
the
slot-attribute-handle-v-for
branch
from
139bf0b
to
6f24c45
Compare
FloEdelmann
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge-case where the slot is dynamic derived from a
v-for.Previously, it would move the
slotdirective in a new<template>above thev-for, which broke it.Now, it also moves the
v-forto the new<template>.