Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-deprecated-slot-attribute): handle v-for with dynamic slot #2529

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(no-deprecated-slot-attribute): handle v-for with dynamic slot #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/rules/syntaxes/slot-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ module.exports = {
// parse error or empty expression
return false
}
const slotName = sourceCode.getText(slotAttr.value.expression).trim()
// If non-Latin characters are included it can not be converted.
// It does not check the space only because `a>b?c:d` should be rejected.
return !/[^a-z]/i.test(slotName)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused about why it's doing this.

I felt like we just want to confirm it's a single Identifier so I went ahead and changed it and it didn't seem to break any tests, but I'm happy to revert this if we want to keep the scope small.


return slotAttr.value.expression.type === 'Identifier'
}

/**
Expand Down Expand Up @@ -102,7 +100,18 @@ module.exports = {
yield fixer.remove(scopeAttr)
}

yield fixer.insertTextBefore(element, `<template ${replaceText}>\n`)
const vFor = startTag.attributes.find(
(attr) => attr.directive && attr.key.name.name === 'for'
)
const vForText = vFor ? `${sourceCode.getText(vFor)} ` : ''
if (vFor) {
yield fixer.remove(vFor)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also considered the case for v-if—would an empty template still cause the parent to think it received an empty slot?

But I confirmed in Vue 2 that these are identical in terms of the parent's this.$slots:

<Parent>
  <div v-if="false" slot="name">
  	slot value
  </div>

  <template slot="name">
    <div v-if="false">
      slot value
    </div>
  </template>
</Parent>


yield fixer.insertTextBefore(
element,
`<template ${vForText}${replaceText}>\n`
)
yield fixer.insertTextAfter(element, `\n</template>`)
}
}
Expand Down
25 changes: 25 additions & 0 deletions tests/lib/rules/no-deprecated-slot-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,31 @@ tester.run('no-deprecated-slot-attribute', rule, {
}
],
errors: ['`slot` attributes are deprecated.']
},
{
code: `
<template>
<my-component>
<slot
v-for="slot in Object.keys($slots)"
:slot="slot"
:name="slot"
></slot>
</my-component>
</template>`,
output: `
<template>
<my-component>
<template v-for="slot in Object.keys($slots)" v-slot:[slot]>
<slot


:name="slot"
></slot>
</template>
</my-component>
</template>`,
errors: ['`slot` attributes are deprecated.']
}
]
})
Loading