Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type information for internal slots and variables #297

Open
wolenetz opened this issue Sep 22, 2021 · 0 comments
Open

Add more type information for internal slots and variables #297

wolenetz opened this issue Sep 22, 2021 · 0 comments

Comments

@wolenetz
Copy link
Member

See #295 (comment)

wolenetz added a commit that referenced this issue Sep 22, 2021
…ate (#295)

Does the updates described in #286, though some remain for future updates
tracked by #297 and #259.

Modernizes to use internal slot for SB append state:
* Use internal slot for SB first initialization segment received flag
* Use internal slot for SB pending initialization segment for changeType flag
* Use internal slot for SourceBuffer's `input buffer`
* Use internal slot for SourceBuffer's `buffer full flag`
* Use internal slot for SB `group start timestamp`
* Use internal slot for SB `group end timestamp`
* Use internal slot for SB `generate timestamps flag`
* Use internal slot for MediaSource `live seekable range`

Also adds a reference to issue #289 in the coded frame eviction
algorithm.

Also adds text in the definition that mentions that `changeType()`

Updates `generate timestamps flag`: Note, this dfn is exported,
so any previous external references to it via
[=generate timestamps flag=] might need to be changed to
{{SourceBuffer/[[generate timestamps flag]]}} wherever it is referenced.
In particular, media-source.js is updated to (hopefully) enable correct
fragment reference for this definition from MSE BSF Registry ED. The
longer-term fix will be to update that registry's respec directly to
use xref and the linkage, above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant