Use internal slots for various MediaSource and SourceBuffer object state #295
Conversation
In eventual squashed commit, reference w3c#286.
Also adds a reference to issue w3c#289 in the coded frame eviction algorithm.
Also adds text in the definition that mentions that `changeType()`
updates `generate timestamps flag`.
Note, this dfn is exported, so any previous external references to it via
[=generate timestamps flag=] might need to be changed to
{{SourceBuffer/[[generate timestamps flag]]}} wherever it is referenced.
In particular, media-source.js is updated to (hopefully) enable correct
fragment reference for this definition from MSE BSF Registry ED. The
longer-term fix will be to update that registry's respec directly to
use xref and the linkage, above.
|
@tidoust / @mwatson2 - Am I correct that the current external reference by the BSF Registry of Also, please review soon if you could, as rebasing this could get ugly since it touches quite a number of lines. Thanks! |
There was a problem hiding this comment.
This all looks good to me! The need to write terms surrounded by [[ ]] and {{ }} in the source spec is not necessarily fantastic from an authoring perspective. Hopefully, the ability to better track and validate references to these terms makes it acceptable.
@tidoust / @mwatson2 - Am I correct that the current external reference by the BSF Registry of generate timestamps flag via the helpers in media-source.js would be more stable if instead that registry used xref to reference the media-source spec, and {{SourceBuffer/[[generate timestamps flag]]}} respec syntax to reference the definition of that internal slot?
Yes and you were right to flag the definition of the internal slot with a data-export attribute so that it can be referenced by the BSF registry.
Thanks for the review. I too noticed some types missing. Some are simple, others like the "track buffer" concept have less strongly typed information, as it is left more to implementations. Possibly this is an area of improvement in the spec though, especially if things like buffered media introspection API is landed (where the notion of an app-visible "track buffer" object might make sense -- I've added a note around this to #259 ). - Edit: and I've also filed #297 |
Note, track buffers and their internal state remain as "variables", not internal slots, in the spec for now. Later refactoring might make them internal slots too, though at lower priority.
This partially fixes #286
Preview | Diff