-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude unused standard types from the schema #964
Comments
Aligning the behaviour of this library exactly with graphql-js is difficult due to lazy loading. Given we don't want to eagerly traverse the schema and all its types, how can we differentiate if a standard scalar is supposed to be included in the schema when calling I think we should strive to align the behaviour with graphql-js if possible, but not at the cost of totally bombing performance. Due to the share-nothing request model of PHP, lazy type loading is very important. |
The current implementation of
Schema
always adds standard scalar types to the schema, even if they are not used. This differs from the reference implementation, which has added quite a few test cases that rely on missing standard scalars.We should align our behaviour with the specification, see http://spec.graphql.org/draft/#sec-Scalars.Built-in-Scalars:
The text was updated successfully, but these errors were encountered: