Add support of SDL to KnownTypeNames validation rule
#999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhenzl
force-pushed
the
rule-known-type-names-sdl
branch
from
e9424cf
to
bef718e
Compare
spawnia
requested changes
Feb 18, 2022
spawnia
added a commit
that referenced
this pull request
Feb 18, 2022
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
Not sure though why they are public.
|
Sorry about this, fortunately I can reopen 😉 |
spawnia
reviewed
Feb 20, 2022
|
This should be good to go now. |
|
No, wait… |
|
Now it's ready. |
|
@vhenzl Smashing those PRs - nice! I am looking towards doing a release once your remaining PRs are in. |
|
Thanks! There is still a lot of work to be done to get those two PRs merged. I'll try my best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
KnownTypeNamesrule to support SDL validation.Corresponding change in the reference implementation: graphql/graphql-js@3b9ea61
The implementation uses
Schema::getType()insteadSchema::getTypeMap()to prevent full schema scan. As result, a test is currently failing because of #997.One test is marked as skipped because of #964.