Fix: Prevent keypress from firing on inputs (#386)

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
withastro · Jul 25, 2023 · e6f6f30 · e6f6f30
1 parent 30ce468
commit e6f6f30
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/quick-peas-deny.md b/.changeset/quick-peas-deny.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/starlight": patch
+---
+
+Prevent search keyboard shortcuts from triggering when input elements are focused
diff --git a/packages/starlight/components/Search.astro b/packages/starlight/components/Search.astro
@@ -96,10 +96,13 @@ const pagefindTranslations = {
 
       // Listen for `/` and `cmd + k` keyboard shortcuts.
       window.addEventListener('keydown', (e) => {
+        const isInput =
+          document.activeElement &&
+          ['input', 'select', 'textarea'].includes(document.activeElement.tagName.toLowerCase());
         if (e.metaKey === true && e.key === 'k') {
           dialog.open ? closeModal() : openModal();
           e.preventDefault();
-        } else if (e.key === '/' && !dialog.open) {
+        } else if (e.key === '/' && !dialog.open && !isInput) {
           openModal();
           e.preventDefault();
         }