Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): update reference/configuration #2296

Merged

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Sep 7, 2024

Description

This PR updates the French version of the reference/configuration page with the changes from #1255.

Copy link

changeset-bot bot commented Sep 7, 2024

⚠️ No Changeset found

Latest commit: 05d16e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 7, 2024
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 05d16e9
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66dd6328aaa0f00008ddeefa
😎 Deploy Preview https://deploy-preview-2296--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/configuration.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @HiDeoo 🚀

Définit si les pages générées par Starlight doivent être pré-rendues en HTML statique ou rendues à la demande par un [adaptateur SSR](https://docs.astro.build/fr/guides/server-side-rendering/).

Les pages Starlight sont pré-rendues par défaut.
Si vous utilisez un adaptateur SSR et que vous souhaitez générer les pages Starlight à la demande, définissez `prerender: false`.
Copy link
Member

@delucis delucis Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain keeps stumbling over “et que vous” instead of “et vous” but I trust you obviously 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah and I see the exact same formulation in the Markdoc guide translation too. I’ll need to go learn what the purpose of the “que” is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's not really mandatory in this case, it's used to avoid a repetition as the sentence technically should be "Si vous utilisez un adaptateur SSR et si vous souhaitez générer les pages Starlight à la demande, …" but to avoid the double "si", we use "que" (which is a "conjonction de subordination" here) for the second one.

Reference

Exemple from the reference:

Si nous cassons quelque chose et qu'elle s'en aperçoit… (= Si nous cassons quelque chose et si elle s'en aperçoit…)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you! Wasn’t at all familiar with that usage of “que”.

@HiDeoo HiDeoo merged commit 367af7e into withastro:main Sep 8, 2024
15 checks passed
@HiDeoo HiDeoo deleted the hd-i18n-fr-0-27-0-reference-configuration branch September 8, 2024 08:44
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Sep 9, 2024
* main: (22 commits)
  i18n(ru): update `ru/manual-setup.mdx` and `ru/reference/configuration.mdx` (withastro#2307)
  [ci] format
  i18n(ru): update some guides (withastro#2306)
  i18n(fr): update `manual-setup` (withastro#2299)
  i18n(fr): update `guides/pages` (withastro#2298)
  [ci] release (withastro#2304)
  Convert URL to file path correctly for Git virtual module (withastro#2303)
  i18n(fr): update `reference/configuration` (withastro#2296)
  i18n(fr): update `guides/authoring-content` (withastro#2297)
  Update `yummacss.com.png` thumbnail (withastro#2301)
  i18n(ko-KR): update `pages.mdx` (withastro#2293)
  [ci] format
  i18n(ko-KR): update `authoring-content.mdx` (withastro#2300)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#2294)
  i18n(ko-KR): update `configuration.mdx` (withastro#2295)
  [ci] release (withastro#2292)
  Add support for SSR (withastro#1255)
  Add Markdoc preset and example (withastro#2249)
  Refactor sidebar persistence logic for better slow device performance (withastro#2242)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants