Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert URL to file path correctly for Git virtual module #2303

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Convert URL to file path correctly for Git virtual module #2303

merged 3 commits into from
Sep 8, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 8, 2024

Description

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 579cdb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 8, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 8, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 579cdb3
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66dd64ee6a3eb200080df793
😎 Deploy Preview https://deploy-preview-2303--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
/index.html 6.15 KB (0%)
/_astro/*.js 22.36 KB (0%)
/_astro/*.css 13.72 KB (0%)

@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 8, 2024
HiDeoo
HiDeoo approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed to me, my local repro with a 👻 directory is working fine with the changes, with or without lastUpdated enabled, in both dev & build 👏

@delucis delucis merged commit f92791a into main Sep 8, 2024
15 checks passed
@delucis delucis deleted the chris/git-fix branch September 8, 2024 09:00
@astrobot-houston astrobot-houston mentioned this pull request Sep 8, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Sep 9, 2024
@HiDeoo
Merge branch 'main' into hd-i18next
4a9f210 
* main: (22 commits)
  i18n(ru): update `ru/manual-setup.mdx` and `ru/reference/configuration.mdx` (withastro#2307)
  [ci] format
  i18n(ru): update some guides (withastro#2306)
  i18n(fr): update `manual-setup` (withastro#2299)
  i18n(fr): update `guides/pages` (withastro#2298)
  [ci] release (withastro#2304)
  Convert URL to file path correctly for Git virtual module (withastro#2303)
  i18n(fr): update `reference/configuration` (withastro#2296)
  i18n(fr): update `guides/authoring-content` (withastro#2297)
  Update `yummacss.com.png` thumbnail (withastro#2301)
  i18n(ko-KR): update `pages.mdx` (withastro#2293)
  [ci] format
  i18n(ko-KR): update `authoring-content.mdx` (withastro#2300)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#2294)
  i18n(ko-KR): update `configuration.mdx` (withastro#2295)
  [ci] release (withastro#2292)
  Add support for SSR (withastro#1255)
  Add Markdoc preset and example (withastro#2249)
  Refactor sidebar persistence logic for better slow device performance (withastro#2242)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module not found: @astrojs/starlight/utils/git.ts
3 participants
@delucis @astrobot-houston @HiDeoo