Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'builderCliOptions' setting #112

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Add 'builderCliOptions' setting #112

merged 1 commit into from
Jul 5, 2017

Conversation

ramijarrar
Copy link
Contributor

We were blocked by this while trying to configure electron-builder to publish artifacts.

Happy to hear your thoughts on an alternative interface.

Enables more advanced scenarios with electron builder e.g for setting up publish configuration.
@wojtkowiak wojtkowiak self-requested a review July 5, 2017 06:41
@wojtkowiak
Copy link
Owner

Hey,
thank you very much for your contribution 🙂
I've never used that feature of electron-builder so at the moment this looks good to me. Just after 1.0 building installer and packaging will be refactored a little bit and probably moved to a plugin so I reserve the right to contact you in order to consult this when I will be working on that part 😉

@wojtkowiak wojtkowiak merged commit f585a93 into wojtkowiak:master Jul 5, 2017
@ramijarrar ramijarrar deleted the builder-cli-options branch July 5, 2017 22:26
@wojtkowiak
Copy link
Owner

@ramijarrar your changes were just released in 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants