Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'builderCliOptions' setting #112

Merged
merged 1 commit into from
Jul 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ field|description
`linkPackages`|array of packages names you want to link (runs `npm link <packageName>` for every package listed)
`packageJsonFields`|fields to add to the generated `package.json` in your desktop app
`builderOptions`|[`electron-builder`](https://github.com/electron-userland/electron-builder) [options](https://github.com/electron-userland/electron-builder/wiki/Options)
`builderCliOptions`|specify additional electron-builder CLI options e.g for [publishing artifacts](https://github.com/electron-userland/electron-builder/wiki/Publishing-Artifacts)
`packagerOptions`|[`electron-packager`](https://github.com/electron-userland/electron-packager) [options](https://github.com/electron-userland/electron-packager/blob/master/docs/api.md)

##### Applying different window options for different OS
Expand Down
1 change: 1 addition & 0 deletions lib/desktop.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ export default class Desktop {
* @property {Object} windowDev
* @property {Object} packageJsonFields
* @property {Object} builderOptions
* @property {Object} builderCliOptions
* @property {Object} packagerOptions
* @property {Object} plugins
* @property {Object} dependencies
Expand Down
4 changes: 2 additions & 2 deletions lib/electronBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ export default class InstallerBuilder {
};

try {
await build({
await build(Object.assign({
targets: this.prepareTargets(),
config: builderOptions
});
}, settings.builderCliOptions));
} catch (e) {
this.log.error('error while building installer: ', e);
}
Expand Down