Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commands] RamseteCommand: default-initialize m_prevSpeeds #5188

Merged
merged 2 commits into from
Mar 14, 2023
Merged

[commands] RamseteCommand: default-initialize m_prevSpeeds #5188

merged 2 commits into from
Mar 14, 2023

Conversation

PeterJohnson
Copy link
Member

Fixes #5187.

@PeterJohnson PeterJohnson requested a review from a team as a code owner March 14, 2023 04:51
Starlight220
Starlight220 previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be simpler to have the variable not null?

@PeterJohnson
Copy link
Member Author

Yes, it would be... changed.

@PeterJohnson PeterJohnson changed the title [commands] RamseteCommand: add null check for m_prevSpeeds [commands] RamseteCommand: default-initialize m_prevSpeeds Mar 14, 2023
@PeterJohnson PeterJohnson merged commit 00abb8c into wpilibsuite:main Mar 14, 2023
@PeterJohnson PeterJohnson deleted the fix-ramsetecommand-crash branch March 14, 2023 06:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starlight220 Starlight220 Starlight220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Java) RamseteCommand putData causes crash if data is read before initialize() called
2 participants
@PeterJohnson @Starlight220