Improve default AprilTag config #5896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagDetector.java
Outdated
Show resolved
Hide resolved
sciencewhiz
reviewed
Nov 8, 2023
|
Are these still reasonable values given the change to 36h11 tag family? |
|
This might still be too loose; in theory, the camera needs to be closer to the tag to detect it properly, so perhaps the pixel threshold should be increased? The issue says too strict is better than too loose. |
|
I doubled the minimum number of pixels required to not reject a quad; the quad now has to be a 20x20 square (or equivalent) for it to not be rejected (which is still fairly small). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the rest of #4920 along with #5895.