Added yarnpkg.cmd batch shim for backwards-compatibility on Windows (#2534) #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #2534, facebook/create-react-app#1555, facebook/create-react-app#1365
Summary
Calling yarnpkg on Windows previously did not call Yarn
yarnpkgcommand is used by create-react-app instead ofyarnto prevent collision with other programs by that name in a user's PATH (See facebook/create-react-app#1365). However on Windows, runningcreate-react-appfalls back to installation via npm because noyarnpkgcommand is found. This PR restores the expected functionality where Yarn is used to install packages for create-react-app if it is installed.Test plan
Tested on Windows 10 x64. Words identically to existing
yarn.cmd.