Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBS end-to-end-testing #78

Closed
wants to merge 19 commits into from
Closed

OBS end-to-end-testing #78

wants to merge 19 commits into from

Conversation

markspolakovs
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Fails
🚫

TODOs without issue key. Please file a Linear ticket and add the number to the comment:

  • + prune: false, // TODO
  • + // TODO: With that in mind, this could be simplified even further - instead of a
Warnings
⚠️

No Linear ticket found. Please include one in either the pull request title (e.g. [BOW-123] Fix something), the description (Fixes BOW-123.), or the branch name (bow-123-fix-something).

Generated by 🚫 dangerJS against 963918b

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 43.93% and project coverage change: +3.45% 🎉

Comparison is base (c7f0fc7) 14.80% compared to head (963918b) 18.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   14.80%   18.25%   +3.45%     
==========================================
  Files         146       37     -109     
  Lines       11353     4781    -6572     
  Branches      282      119     -163     
==========================================
- Hits         1681      873     -808     
+ Misses       9672     3908    -5764     
Files Changed Coverage Δ
desktop/src/main/main.ts 0.00% <0.00%> (ø)
desktop/src/main/settings.ts 0.00% <0.00%> (ø)
desktop/src/renderer/.eslintrc.cjs 0.00% <ø> (ø)
desktop/src/renderer/MainScreen.tsx 0.00% <0.00%> (ø)
desktop/src/renderer/screens/OBS.tsx 0.00% <0.00%> (ø)
desktop/src/main/vmix.ts 80.19% <100.00%> (+1.08%) ⬆️

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markspolakovs
Copy link
Member Author

markspolakovs commented Aug 30, 2023

Plan of attack: this PR will probably get closed and broken apart into multiple PRs:

  • One with the zod-prisma-types explosion
  • One with the newly added OBS tests and MockOBSWebSocket
  • One with the test:integration refactor
  • Probably multiple to sort out the packaging/bundling/module resolution mess:
    • Probably need to run depcheck over all the workspaces
    • The cjs->mjs move in Desktop, and ensuing fallout
    • Hopefully pruning will still work, but if not, one disabling that

Ideally I'd work out a way of having the tests as a PR that I can rebase onto various module changes, as a sanity check. Rebases ahoy!

😭

@markspolakovs
Copy link
Member Author

Closing in favour of #87 #88 #91 and #92.

@markspolakovs markspolakovs deleted the obs-testing branch September 7, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants