Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOW-69] Add tests for desktop downloading media #91

Merged
merged 21 commits into from
Sep 7, 2023

Conversation

markspolakovs
Copy link
Member

@markspolakovs markspolakovs commented Sep 6, 2023

Resolves BOW-69.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Fails
🚫

TODOs without issue key. Please file a Linear ticket and add the number to the comment:

  • + // TODO: OBS testing isn't implemented yet so the UI won't display the continuity
  • + // TODO: For some reason this assertion can fail - possibly because the download
  • + targetType: z.enum(["rundownItem", "continuityItem"]), // TODO: support assets

Generated by 🚫 dangerJS against 9e375b1

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (69a7c8c) 2.82% compared to head (9e375b1) 2.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #91      +/-   ##
========================================
- Coverage   2.82%   2.82%   -0.01%     
========================================
  Files        885     885              
  Lines      29315   29384      +69     
  Branches     925     925              
========================================
  Hits         829     829              
- Misses     28486   28555      +69     
Files Changed Coverage Δ
server/app/api/_router.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markspolakovs markspolakovs changed the title Add tests for desktop downloading media [BOW-69] Add tests for desktop downloading media Sep 6, 2023
@markspolakovs
Copy link
Member Author

Overriding TODO check - they're all related to tests that are coming shortly anyway.

@markspolakovs markspolakovs merged commit 91ce76d into main Sep 7, 2023
10 of 11 checks passed
@markspolakovs markspolakovs deleted the obs-testing-3--media-downloading branch September 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants