refactor: remove unnecessary retry logic from data injection

[phillebaba]

Description

This change removes the retrying in data injections, as it does not have any effect. The current implementation will only retry at a single condition which is when the pods returned from the wait function is empty.

zarf/src/pkg/cluster/data.go

Lines 88 to 90 in 0943d76

	if len(pods) < 1 {
	continue
	}

This event wont actually happen because the wait logic will run until the context cancelled if the pod list is empty. This means that returning an empty list is impossible.

Removing the nested retry implementation increases legibility.

Related Issue

Depends on #2856

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Files	Patch %	Lines
src/pkg/cluster/data.go	0.00%	56 Missing ⚠️

Files	Coverage Δ
src/pkg/cluster/data.go	0.00% <0.00%> (ø)

[schristoff]

tests please

[phillebaba]

The data injection can not be tested in its current state as it is shelling out to both tar and kubectl. What exactly should be tested here maybe other than waitForPodsAndContainers ?

[schristoff]

Yeah, upon re-review it will be too burdensome to try and write functional tests for HandleDataInjection without a major refactor of the functionality itself.