feat: better error message on helm fail #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
changed the title
Codecov ReportAttention: Patch coverage is
|
schristoff
previously approved these changes
Aug 21, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
schristoff
approved these changes
Aug 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mjnagel
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Aug 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | patch | `v0.38.2` -> `v0.38.3` | | [zarf-dev/zarf](https://github.com/zarf-dev/zarf) | patch | `v0.38.2` -> `v0.38.3` | --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.38.3`](https://github.com/zarf-dev/zarf/releases/tag/v0.38.3) [Compare Source](https://github.com/zarf-dev/zarf/compare/v0.38.2...v0.38.3) #### What's Changed - fix: linter warnings in new Golang CI version by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2883 - chore(deps): bump github.com/go-git/go-git/v5 from 5.11.0 to 5.12.0 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2871 - chore(deps): bump github/codeql-action from 3.26.0 to 3.26.1 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2881 - test: move oci compose tests that don't need cluster by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2878 - chore(deps): bump github.com/mikefarah/yq/v4 from 4.44.2 to 4.44.3 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2870 - refactor: findImages to return errors immediately by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2851 - test: add workflow to make sure importing Zarf works by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2874 - refactor: remove unnecessary retry logic from data injection by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2867 - docs: explain no wait & helm hooks interaction by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2895 - refactor: store managed secrets and add tests by [@​phillebaba](https://github.com/phillebaba) in [zarf-dev/zarf#2892 - chore(deps): bump github/codeql-action from 3.26.1 to 3.26.2 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2888 - chore(deps): bump actions/setup-go from 5.0.0 to 5.0.2 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2901 - fix: update injector by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2910 - chore(deps): bump github/codeql-action from 3.26.2 to 3.26.4 by [@​dependabot](https://github.com/dependabot) in [zarf-dev/zarf#2916 - fix: update creds not breaking when internal git server not deployed by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2904 - feat: better error message on helm fail by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2914 - ci: increase lint timeout by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2919 - fix: evaulate templates on schema check by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2911 - chore: update workflow to use new key by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2920 - ci: permission at job level by [@​AustinAbro321](https://github.com/AustinAbro321) in [zarf-dev/zarf#2922 **Full Changelog**: zarf-dev/zarf@v0.38.2...v0.38.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a recent change, we stopped giving the helm install error as a warning to users.
I considered keeping it a warning or appending it to the other errors. The warning looked nicer, but only because newlines look weird with how are error messages are formatted in pterm. Changed the error message to be paragraphed and went with that.
warning:
error:
error (paragraph formatting):
Related Issue
Fixes: #2907
Checklist before merging