Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate API reference docs #1918

Merged
merged 11 commits into from
Jun 24, 2024
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 27, 2024

This uses sphinx-autoapi to automatically generate API reference for v3, replacing a lot of manually created .rst pages that were present for v2. Currently only for the zarr namespace, but can (and should) be expanded to sub-modules in a follow up PR.

See https://zarr--1918.org.readthedocs.build/en/1918/api/index.html for the current build of this PR; feedback welcome. There are definitely improvements to be made here, but I think worth getting this in as a first go at the API reference.

@dstansby dstansby changed the title Automatically generate API reference Automatically generate API reference docs May 27, 2024
@dstansby dstansby mentioned this pull request May 27, 2024
6 tasks
@dstansby dstansby force-pushed the autoapi branch 2 times, most recently from f649442 to 7cd3b56 Compare May 28, 2024 15:44
@d-v-b
Copy link
Contributor

d-v-b commented Jun 6, 2024

I didn't review this in detail but i like the effort, and auto docs >>> no docs IMO

@dstansby dstansby marked this pull request as ready for review June 7, 2024 17:18
@d-v-b d-v-b self-requested a review June 24, 2024 14:23
@d-v-b d-v-b merged commit 11a959a into zarr-developers:v3 Jun 24, 2024
17 of 18 checks passed
@d-v-b
Copy link
Contributor

d-v-b commented Jun 24, 2024

thanks @dstansby !

@dstansby dstansby deleted the autoapi branch June 24, 2024 14:32
@jakirkham
Copy link
Member

Thanks all! 🙏

It looks like RTD is failing. Would someone here be able to take a look? 🙂

@d-v-b
Copy link
Contributor

d-v-b commented Jun 24, 2024

@jakirkham I'm not too familiar with RTD but I can try to sort things out. Can you elaborate on where the problem is evident? E.g., what should I be looking at?

I checked https://zarr.readthedocs.io/en/v3/ and https://zarr.readthedocs.io/en/stable/, both look fine to me

@dstansby
Copy link
Contributor Author

See the v3 builds at https://app.readthedocs.org/projects/zarr/builds/. #1985 should be a fix.

@jakirkham
Copy link
Member

Thank you both! 🙏

Yep David linked the right place to look. As RTD will just show the last successful build, looking at the doc pages themselves is unfortunately not as helpful. Maybe they could have a banner to note the doc builds or failing or something

Have gone ahead and merged David's fix. Let's see if that helps 🍀

@jakirkham
Copy link
Member

Fixed with PRs:

Doc builds are now passing again! 🎉

dcherian added a commit to dcherian/zarr-python that referenced this pull request Jun 25, 2024
* v3: (22 commits)
  [v3] `Buffer` ensure correct subclass based on the `BufferPrototype` argument (zarr-developers#1974)
  Fix doc build (zarr-developers#1987)
  Fix doc build warnings (zarr-developers#1985)
  Automatically generate API reference docs (zarr-developers#1918)
  Update `RemoteStore.__str__` and add UPath tests (zarr-developers#1964)
  [v3] Elevate codec pipeline (zarr-developers#1932)
  0 dim arrays: indexing (zarr-developers#1980)
  `parse_shapelike` allows 0 (zarr-developers#1979)
  Clean up typing and docs for indexing (zarr-developers#1961)
  add json indentation to config (zarr-developers#1952)
  chore: update pre-commit hooks (zarr-developers#1973)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#1969)
  chore: update pre-commit hooks (zarr-developers#1957)
  Update release.rst (zarr-developers#1960)
  doc: update release notes for 3.0.0.alpha (zarr-developers#1959)
  Basic working FsspecStore (zarr-developers#1785)
  Feature: Top level V3 API (zarr-developers#1884)
  Buffer Prototype Argument (zarr-developers#1910)
  Create issue-metrics.yml
  fixes bug in transpose (zarr-developers#1949)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants