Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up typing and docs for indexing #1961

Merged
merged 19 commits into from
Jun 19, 2024
Merged

Clean up typing and docs for indexing #1961

merged 19 commits into from
Jun 19, 2024

Conversation

brokkoli71
Copy link
Member

@brokkoli71 brokkoli71 commented Jun 12, 2024 •
edited
Loading

fixes #1946

Changes:

d-v-b
d-v-b reviewed Jun 12, 2024
View reviewed changes
src/zarr/indexing.py Outdated Show resolved Hide resolved
@brokkoli71 brokkoli71 changed the title Clean up typing and docs for indexing [WIP] Clean up typing and docs for indexing Jun 12, 2024
d-v-b
d-v-b approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement! The beastiary of types in indexing.py is still a problem, but I think we should try solve that at the level of the indexing API itself

@brokkoli71 brokkoli71 marked this pull request as ready for review June 14, 2024 16:01
@brokkoli71 brokkoli71 requested a review from d-v-b June 14, 2024 16:01
@brokkoli71 brokkoli71 changed the title [WIP] Clean up typing and docs for indexing Clean up typing and docs for indexing Jun 15, 2024
normanrz
normanrz approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@normanrz normanrz merged commit d4c25b2 into zarr-developers:v3 Jun 19, 2024
18 checks passed
@normanrz normanrz deleted the clean-up-typing-and-docs-for-indexing branch June 19, 2024 07:33
dcherian added a commit to dcherian/zarr-python that referenced this pull request Jun 25, 2024
@dcherian
Merge branch 'v3' into hypothesis-tests
3a560ed 
* v3: (22 commits)
  [v3] `Buffer` ensure correct subclass based on the `BufferPrototype` argument (zarr-developers#1974)
  Fix doc build (zarr-developers#1987)
  Fix doc build warnings (zarr-developers#1985)
  Automatically generate API reference docs (zarr-developers#1918)
  Update `RemoteStore.__str__` and add UPath tests (zarr-developers#1964)
  [v3] Elevate codec pipeline (zarr-developers#1932)
  0 dim arrays: indexing (zarr-developers#1980)
  `parse_shapelike` allows 0 (zarr-developers#1979)
  Clean up typing and docs for indexing (zarr-developers#1961)
  add json indentation to config (zarr-developers#1952)
  chore: update pre-commit hooks (zarr-developers#1973)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#1969)
  chore: update pre-commit hooks (zarr-developers#1957)
  Update release.rst (zarr-developers#1960)
  doc: update release notes for 3.0.0.alpha (zarr-developers#1959)
  Basic working FsspecStore (zarr-developers#1785)
  Feature: Top level V3 API (zarr-developers#1884)
  Buffer Prototype Argument (zarr-developers#1910)
  Create issue-metrics.yml
  fixes bug in transpose (zarr-developers#1949)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@d-v-b d-v-b Awaiting requested review from d-v-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up typing and docs for indexing
3 participants
@brokkoli71 @normanrz @d-v-b