Silence hypothesis complex warning #2157
Open
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
fix-hypothesis-complex-warning
branch
from
c55ffa4
to
4a8fca0
Compare
dcherian
force-pushed
the
fix-hypothesis-complex-warning
branch
from
4a8fca0
to
eeaea6a
Compare
dstansby
reviewed
Sep 9, 2024
jhamman
approved these changes
Sep 10, 2024
dstansby
requested changes
Sep 13, 2024
There was a problem hiding this comment.
I'm going to mark as request changes so this doesn't get merged before https://github.com/zarr-developers/zarr-python/pull/2157/files#r1757019017 is discussed. Given this is public API I think we should at least document the behaviour, and possibly add a equal_nan keyword argument to signal that the behaviour is different to default numpy behaviour. (or I guess make it private API...)
* v3: fix: opening a group with unspecified format finds either v2 or v3 (zarr-developers#2183) test: check that store, array, and group classes are serializable (zarr-developers#2006) feature(store): V3 ZipStore (zarr-developers#2078) More typing fixes for tests (zarr-developers#2173) refactor: split metadata into v2 and v3 modules (zarr-developers#2163) Accept dictionaries for `store` argument (zarr-developers#2164) Simplify mypy config for tests (zarr-developers#2156) Fixed path segment duplication in open_array (zarr-developers#2167) Fixed test warnings (zarr-developers#2168) chore: update pre-commit hooks (zarr-developers#2165) Ensure that store_dict used for empty dicts (zarr-developers#2162) Bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.1 in the actions group (zarr-developers#2160)
6 tasks
TomAugspurger
approved these changes
Sep 16, 2024
dstansby
approved these changes
Sep 17, 2024
| assert np.isnan(arr.fill_value) | ||
| assert arr.fill_value.dtype == arr.dtype | ||
| # all fill value chunk is an empty chunk, and should not be written | ||
| assert not [a async for a in store.list_prefix("/")] |
There was a problem hiding this comment.
Suggested change
| assert not [a async for a in store.list_prefix("/")] | |
| assert len([a async for a in store.list_prefix("/")]) == 0 |
I think makes it clearer that the check is for zero chunks written?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2155
[Description of PR]
TODO: