This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Ensure setting save_path considers save_handler #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in zendframework#99, while correct, did not address setting the session.save_path for non-files save handlers when the save handler is set via `setOption('save_handler', $value)`. The reason for this was due to the fact that `setOption()` delegates directly to `setStorageOption()` instead of the relevant class method; the changes in zendframework#99 make that method a no-op in the case of a save handler option. What this patch does is two-fold: - It overrides `setOption()` and has it call `setPhpSaveHandler()` if `save_handler` is provided as the `$option` argument. It then returns on completion. Otherwise, it delegates to the parent. - It modifies `setPhpSaveHandler()` to extract the bulk of the logic to a new method, `performSaveHandlerUpdate()`. This new method now returns the save handler _name_ to store. `setPhpSaveHandler()` then sets that name as the `save_handler` value in the `$options` property before returning. I have added a test to verify this behavior based on an example provided in zendframework#98.
weierophinney
force-pushed
the
hotfix/98-redis-path
branch
from
e52b095
to
02c7039
Compare
PHPUnit 6.5+ updates to use php-mock-objects ^5.0. Unfortunately, phpunit still typehints against interfaces defined in the v4 release, causing breakage when using the invocation builder to setup your mock expectations.
weierophinney
force-pushed
the
hotfix/98-redis-path
branch
4 times, most recently
from
0d865fa
to
8d044fe
Compare
6.0.13 has fixes necessary to work with PHP 7.2. Also sets that as the minimum version PHP 7.2 will install when running the 7.2-lowest target.
weierophinney
force-pushed
the
hotfix/98-redis-path
branch
from
8d044fe
to
acff5d9
Compare
weierophinney
added a commit
that referenced
this pull request
Dec 1, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 1, 2017
Forward port #101 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #99, while correct, did not address setting the session.save_path for non-files save handlers when the save handler is set via
setOption('save_handler', $value). The reason for this was due to the fact thatsetOption()delegates directly tosetStorageOption()instead of the relevant class method; the changes in #99 make that method a no-op in the case of a save handler option.What this patch does is two-fold:
setOption()and has it callsetPhpSaveHandler()ifsave_handleris provided as the$optionargument. It then returns on completion. Otherwise, it delegates to the parent.setPhpSaveHandler()to extract the bulk of the logic to a new method,performSaveHandlerUpdate(). This new method now returns the save handler name to store.setPhpSaveHandler()then sets that name as thesave_handlervalue in the$optionsproperty before returning.I have added a test to verify this behavior based on an example provided in #98.