Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Ensure setting save_path considers save_handler #101

Merged
merged 3 commits into from
Dec 1, 2017
Merged

Ensure setting save_path considers save_handler #101

merged 3 commits into from
Dec 1, 2017

Commits on Dec 1, 2017

  1. Ensure setting save_path considers save_handler 

    The fix in zendframework#99, while correct, did not address setting the session.save_path
for non-files save handlers when the save handler is set via
`setOption('save_handler', $value)`. The reason for this was due to the
fact that `setOption()` delegates directly to `setStorageOption()`
instead of the relevant class method; the changes in zendframework#99 make that
method a no-op in the case of a save handler option.

What this patch does is two-fold:

- It overrides `setOption()` and has it call `setPhpSaveHandler()` if
  `save_handler` is provided as the `$option` argument. It then returns
  on completion. Otherwise, it delegates to the parent.
- It modifies `setPhpSaveHandler()` to extract the bulk of the logic to
  a new method, `performSaveHandlerUpdate()`. This new method now
  returns the save handler _name_ to store. `setPhpSaveHandler()` then
  sets that name as the `save_handler` value in the `$options` property
  before returning.

I have added a test to verify this behavior based on an example provided
in zendframework#98.
    @weierophinney
    weierophinney committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    02c7039 View commit details
    Browse the repository at this point in the history

  2. Mark as conflicting with phpunit 6.5+ 

    PHPUnit 6.5+ updates to use php-mock-objects ^5.0. Unfortunately,
phpunit still typehints against interfaces defined in the v4 release,
causing breakage when using the invocation builder to setup your mock
expectations.
    @weierophinney
    weierophinney committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    c323a94 View commit details
    Browse the repository at this point in the history

  3. Updates minimum supported PHPUnit 6.X version 

    6.0.13 has fixes necessary to work with PHP 7.2. Also sets that as the
minimum version PHP 7.2 will install when running the 7.2-lowest target.
    @weierophinney
    weierophinney committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    acff5d9 View commit details
    Browse the repository at this point in the history