simplify formatting of label details #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 75.72% 76.54% +0.81%
==========================================
Files 35 35
Lines 10212 10100 -112
==========================================
- Hits 7733 7731 -2
+ Misses 2479 2369 -110 ☔ View full report in Codecov by Sentry. |
Techatrix
added a commit
that referenced
this pull request
Feb 11, 2024
- bring back the label details (accidentally removed in #1746) - remove the function name from the detail - differentiate between functions and methods
Techatrix
added a commit
that referenced
this pull request
Feb 11, 2024
- bring back the label details (accidentally removed in #1746) - remove the function name from the detail - differentiate between functions and methods - add empty parentheses when there are no arguments even if snippets are disabled
Techatrix
added a commit
that referenced
this pull request
Feb 11, 2024
- bring back the label details (accidentally removed in #1746) - remove the function name from the detail - differentiate between functions and methods - add empty parentheses when there are no arguments even if snippets are disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
formatDetailedLabelfunction that used to do the cleanup of the label details. I've instead adjusted the code that creates the label detail.