Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve completions on functions #1763

Merged
merged 1 commit into from
Feb 11, 2024
Merged

improve completions on functions #1763

merged 1 commit into from
Feb 11, 2024

Conversation

Techatrix
Copy link
Member

  • bring back the label details (accidentally removed in simplify formatting of label details #1746)
  • remove the function name from the detail
  • differentiate between functions and methods
  • add empty parentheses when there are no arguments even if snippets are disabled

@Techatrix
improve completions on functions
74afea4 
- bring back the label details (accidentally removed in #1746)
- remove the function name from the detail
- differentiate between functions and methods
- add empty parentheses when there are no arguments even if snippets are disabled
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6478f1a) 76.58% compared to head (74afea4) 76.62%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/analysis.zig 96.55% 2 Missing ⚠️
src/Server.zig 0.00% 1 Missing ⚠️
src/features/completions.zig 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
+ Coverage   76.58%   76.62%   +0.04%     
==========================================
  Files          35       35              
  Lines       10088    10114      +26     
==========================================
+ Hits         7726     7750      +24     
- Misses       2362     2364       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

llogick
llogick approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@llogick llogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy work

@Techatrix Techatrix merged commit 2489add into master Feb 11, 2024
12 checks passed
@Techatrix Techatrix deleted the techatrix/function-completions branch February 11, 2024 23:46
@Techatrix Techatrix mentioned this pull request Feb 27, 2024
Closed
@Techatrix Techatrix mentioned this pull request Mar 28, 2024
Merged
@nwormek nwormek mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogick llogick llogick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techatrix @llogick