Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Hooks: Add support for 'exhaustive-deps' rule #56

Closed
simmo opened this issue Feb 25, 2019 · 1 comment
Closed

React Hooks: Add support for 'exhaustive-deps' rule #56

simmo opened this issue Feb 25, 2019 · 1 comment
Assignees
@simmo
Labels
enhancement New feature or request
Milestone
4.2.0

Comments

@simmo
Copy link
Contributor

simmo commented Feb 25, 2019

Package (if applicable)
eslint-config-react

Is your feature request related to a problem? Please describe.
Add suport for the new react-hooks/exhaustive-deps rule in the eslint hooks plugin.

Describe the solution you'd like
Add the rule as warning.

Describe alternatives you've considered
N/A

Additional context
N/A
@simmo simmo added the enhancement New feature or request label Feb 25, 2019
@simmo simmo added this to the 4.2.0 milestone Feb 25, 2019
@simmo simmo self-assigned this Feb 25, 2019
@simmo
Copy link
Contributor Author

simmo commented Feb 25, 2019

Refs:
facebook/react#14920
facebook/react#14636

@simmo simmo closed this as completed in 3e3acca Feb 25, 2019
simmo added a commit that referenced this issue Feb 25, 2019
@simmo
Merge pull request #57 from zone/feature/56-hook-exhaustive-deps-rule
c864f05 
Fixes #56, adding "react-hooks/exhaustive-deps" rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simmo simmo

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
1 participant
@simmo