Fixes #56, adding "react-hooks/exhaustive-deps" rule #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simmo
commented
Feb 25, 2019
| @@ -2,6 +2,7 @@ module.exports = { | |||
| extends: ['plugin:react/recommended', '@zonedigital/eslint-config-zone'], | |||
| plugins: ['react-hooks'], | |||
| rules: { | |||
| 'react-hooks/exhaustive-deps': 'warn', | |||
There was a problem hiding this comment.
I've added this as a warning for the moment as, although released and stable it appears the output is still under review. Kinda feel like we should have this as an error in the long term as not doing the hook dependencies fully will cause needless re-rending/processing.
arashkiani
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR cover?
Feature
Breaking change?
No
Are all the tests are passing?
Yes
Other information: