Use libidn2 instead of libidn #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
ghost
requested review from
matsduf
approved these changes
Apr 28, 2022
|
The failure in Github Action comes from the fact that we test against Zonemaster::LDNS master state which does not support libidn2 yet. This is at this stage only available in develop. To be sure all tests are successful against develop, I opened #1058 and removed the |
This was referenced Apr 28, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace libidn with libidn2.
Context
zonemaster/zonemaster-ldns#133
Changes
Update Installation.md document and Github Action file.
How to test this PR
Install Zonemaster-LDNS that uses libidn2 and all tests should pass.