Momentarily comment out "latest" from Github Action #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
changed the title
|
Travis is better in that respect. There we test develop branch against develop branch. To resolve this kind of issue last time we commented master branch. I suggest that we do that again instead, because then we will know that develop build against develop without any modifications. |
Momentarily drop the unit tests relying on fetching Zonemaster::LDNS from CPAN due to an incompatibility with the required version of libidn. The CPAN module requires libidn11-dev, but current develop migrated to libidn2-dev.
ghost
changed the title
Good point. I've commented out the part that will configure the failing tests. |
matsduf
approved these changes
May 4, 2022
|
The issue already exists: #899 |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Momentarily drop the unit tests relying on fetching Zonemaster::LDNS from CPAN due to an incompatibility with the required version of libidn. The CPAN module requires libidn11-dev, but current develop migrated to libidn2-dev.
Context
Github Action is failing since merging #1056.
Changes
Github Action file.
How to test this PR
Tests should pass.