Fix for Terraform issue in which the tier 2 subscription parameter is ignored #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
approved these changes
Feb 9, 2022
Breanna-Stryker
added a commit
that referenced
this pull request
Feb 21, 2022
* Check that Portal UI form outputs map to template parameter inputs on pull requests (#620) * Move the workflow scripts to where they're used (#632) * Update descriptions in alt text on main README.md (#633) * Add spike issue template and remove feature request issue template (#635) * Fix for Terraform issue in which the tier 2 subscription parameter is ignored (#638) * Process for handling a broken build (#641) * Clean-up nightly deployments using Azure CLI (#642) * Add instructions for ASC/Defender cleanup (#643) * Pin Bicep to v0.4.1272 (#650) * SBOM generation in PR (#648) * Update policy assignment resource provider version (#652) * Generate SBOMs without .git contents (#654) * Generate SBOM files during PR events (#656) * check to see if the SBOM needs to be regenerated before running the pipeline again * Update Software Bill of Materials (SBOM) Co-authored-by: Microsoft.VisualStudio.Services.TFS <> Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: Vidya Bala <vidbala@microsoft.com> Co-authored-by: JeromeJansen <jjansen23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in which the
coalescestatement to determine which subscription to deploy tier 2 into has the wrong parameter order.Issue reference
The issue this PR will close: #637
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list:
The documentation is updated to cover any new or changed features