Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Bicep to v0.4.1272 #650

Merged
merged 10 commits into from
Feb 16, 2022
Merged

Pin Bicep to v0.4.1272 #650

merged 10 commits into from
Feb 16, 2022

Conversation

glennmusa
Copy link
Contributor

Description

This change:

  • Updates the devcontainer Dockerfile to accept a BICEP_VERSION argument and pins it to v0.4.1272
  • Updates the validate-build-bicep workflow to set a BICEP_VERSION argument and pins it to v0.4.1272
  • Makes updates to source to fix explicit-values-for-loc-params Bicep warnings that occur when upgrading Bicep to v0.4.1272

Issue reference

The issue this PR will close: #646

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from a team as a code owner February 15, 2022 22:34
@glennmusa glennmusa enabled auto-merge (squash) February 15, 2022 22:43
@brooke-hamilton brooke-hamilton self-assigned this Feb 16, 2022
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glennmusa glennmusa merged commit 318ee1a into main Feb 16, 2022
@glennmusa glennmusa deleted the glenn/pinBicep branch February 16, 2022 19:48
Breanna-Stryker added a commit that referenced this pull request Feb 21, 2022
* Check that Portal UI form outputs map to template parameter inputs on pull requests (#620)

* Move the workflow scripts to where they're used (#632)

* Update descriptions in alt text on main README.md (#633)

* Add spike issue template and remove feature request issue template (#635)

* Fix for Terraform issue in which the tier 2 subscription parameter is ignored (#638)

* Process for handling a broken build (#641)

* Clean-up nightly deployments using Azure CLI (#642)

* Add instructions for ASC/Defender cleanup (#643)

* Pin Bicep to v0.4.1272 (#650)

* SBOM generation in PR (#648)

* Update policy assignment resource provider version (#652)

* Generate SBOMs without .git contents (#654)

* Generate SBOM files during PR events (#656)

* check to see if the SBOM needs to be regenerated before running the pipeline again

* Update Software Bill of Materials (SBOM)

Co-authored-by: Microsoft.VisualStudio.Services.TFS <>

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Vidya Bala <vidbala@microsoft.com>
Co-authored-by: JeromeJansen <jjansen23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Use a specific version of Bicep in the devcontainer and in automation
2 participants