Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for ASC/Defender cleanup #643

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

brooke-hamilton
Copy link
Contributor

Description

Adds instructions for cleaning up Azure Security Center/Defender configuration applied when the deployASC=true parameter is used to deploy MLZ.

NOTE: The guidance still refers to "Azure Security Center" in order to be consistent with other docs and code in the repo. Another backlog item will cover changing the name to Azure Defender for Cloud.

Issue reference

The issue this PR will close: #570

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed (tested script examples in the markdown)
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton requested a review from a team as a code owner February 11, 2022 21:01
@brooke-hamilton brooke-hamilton changed the title add instructions for ASC/Defender cleanup Add instructions for ASC/Defender cleanup Feb 11, 2022
@brooke-hamilton brooke-hamilton enabled auto-merge (squash) February 11, 2022 21:13
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions appear to be clear and concise
Very well done!

@brooke-hamilton brooke-hamilton merged commit 593b4eb into main Feb 14, 2022
@brooke-hamilton brooke-hamilton deleted the brooke/asc-policy-cleanup branch February 14, 2022 14:42
Breanna-Stryker added a commit that referenced this pull request Feb 21, 2022
* Check that Portal UI form outputs map to template parameter inputs on pull requests (#620)

* Move the workflow scripts to where they're used (#632)

* Update descriptions in alt text on main README.md (#633)

* Add spike issue template and remove feature request issue template (#635)

* Fix for Terraform issue in which the tier 2 subscription parameter is ignored (#638)

* Process for handling a broken build (#641)

* Clean-up nightly deployments using Azure CLI (#642)

* Add instructions for ASC/Defender cleanup (#643)

* Pin Bicep to v0.4.1272 (#650)

* SBOM generation in PR (#648)

* Update policy assignment resource provider version (#652)

* Generate SBOMs without .git contents (#654)

* Generate SBOM files during PR events (#656)

* check to see if the SBOM needs to be regenerated before running the pipeline again

* Update Software Bill of Materials (SBOM)

Co-authored-by: Microsoft.VisualStudio.Services.TFS <>

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Vidya Bala <vidbala@microsoft.com>
Co-authored-by: JeromeJansen <jjansen23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add cleanup instructions for policy assignments and Azure Security Center/Defender
2 participants