fix(dot/rpc/modules): rpc.state.queryStorage fixed #2565

edwardmack · 2022-05-20T19:25:48Z

Changes

Fix the implementation of rpc.state.queryStorage so that it's working in a manner that matches specification outlined in spec
Fix RPC module, which in turn fixed issues found when testing with polkadot.js/api.

Tests

Unit tests

go test github.com/ChainSafe/gossamer/dot/rpc/modules -v -run TestStateModuleQueryStorage

RPC test, start gossamer with dev chain (testing with runtime API v0.9.19), then cURL to call RPC function. NOTE: param 2 (and 3 optional) must be a valid block hash, so these value may not work for your run, check node's output logs to find and use valid block hashes.

curl --location --request POST 'http://127.0.0.1:8545' \
--header 'Content-Type: application/json' \
--data-raw '{
    "jsonrpc": "2.0",
    "method": "state_queryStorage",
    "params": [["0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", "0xc2261276cc9d1f8598ea4b6a74b15c2f57c875e4cff74148e4628f264b974c80"],"0x0a0f4687cfc807af53e28beb2b504c015d1db34e44126e4af9e5489473fe205b", "0x1078d06e0b445f32eaf57ac8aac2fec73101b9def070e1e44e15f50b800cc0d0"],
    "id": 1
}'

Test with polkadot.js/api use code snip below, note as above make sure to use valid block hashes when testing.

const queryStorage = await
        api.rpc.state.queryStorage(["0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", "0xc2261276cc9d1f8598ea4b6a74b15c2f57c875e4cff74148e4628f264b974c80"], "0x0a0f4687cfc807af53e28beb2b504c015d1db34e44126e4af9e5489473fe205b", "0x1078d06e0b445f32eaf57ac8aac2fec73101b9def070e1e44e15f50b800cc0d0");
    console.log('\x1b[32m%s\x1b[0m %s', "queryStorage:", JSON.stringify(queryStorage, null, 4));

Issues

closes: #2536

Primary Reviewer

@timwu20

codecov · 2022-05-25T19:58:24Z

Codecov Report

Merging #2565 (aaf8fa4) into development (191f770) will increase coverage by 0.64%.
The diff coverage is 97.72%.

❗ Current head aaf8fa4 differs from pull request most recent head dd41f16. Consider uploading reports for the commit dd41f16 to get more accurate results

@@               Coverage Diff               @@
##           development    #2565      +/-   ##
===============================================
+ Coverage        62.42%   63.07%   +0.64%     
===============================================
  Files              211      211              
  Lines            27347    27065     -282     
===============================================
- Hits             17072    17070       -2     
+ Misses            8635     8449     -186     
+ Partials          1640     1546      -94

Flag	Coverage Δ
unit-tests	`63.07% <97.72%> (+0.64%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/core/service.go	`74.85% <ø> (-0.28%)`	⬇️
dot/rpc/modules/api_mocks.go	`0.00% <0.00%> (ø)`
dot/rpc/http.go	`83.10% <100.00%> (+0.11%)`	⬆️
dot/rpc/modules/state.go	`94.84% <100.00%> (+0.75%)`	⬆️
internal/log/options.go	`91.42% <0.00%> (-8.58%)`	⬇️
dot/telemetry/mailer.go	`56.71% <0.00%> (-4.48%)`	⬇️
lib/babe/verify.go	`88.88% <0.00%> (-2.35%)`	⬇️
dot/sync/message.go	`66.21% <0.00%> (-0.68%)`	⬇️
dot/network/service.go	`56.74% <0.00%> (-0.47%)`	⬇️
lib/grandpa/message_handler.go	`56.46% <0.00%> (-0.01%)`	⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191f770...dd41f16. Read the comment docs.

chain/dev/config.toml

dot/rpc/modules/api.go

dot/rpc/modules/errors.go

dot/rpc/modules/state.go

tests/polkadotjs_test/test_copy.js

timwu20

do we need chain/dev/dev-spec-raw_gssmr9190.json in this PR?

timwu20

do we need chain/dev/dev-spec-raw_gssmr9190.json in this PR?

timwu20 · 2022-06-29T01:15:19Z

dot/rpc/modules/state.go

+			var hexValue *string
+			if len(value) > 0 {
+				hexValue = new(string)
+				*hexValue = common.BytesToHex(value)
+			}

-		blochHash := block
+			if firstPass {
+				changes = append(changes, [2]*string{stringPtr(key), hexValue})
+				lastValue[j] = hexValue
+				continue
+			}
+			if lastValue[j] == nil && hexValue != nil {
+				changes = append(changes, [2]*string{stringPtr(key), hexValue})
+				lastValue[j] = hexValue
+			}
+			if lastValue[j] != nil && *lastValue[j] != *hexValue {
+				changes = append(changes, [2]*string{stringPtr(key), hexValue})
+				lastValue[j] = hexValue
+			}


var hexValue string if len(value) > 0 { hexValue = common.BytesToHex(value) } if firstPass { changes = append(changes, [2]*string{stringPtr(key), &hexValue}) lastValue[j] = &hexValue continue } if lastValue[j] == nil && &hexValue != nil { changes = append(changes, [2]*string{stringPtr(key), &hexValue}) lastValue[j] = &hexValue } if lastValue[j] != nil && *lastValue[j] != hexValue { changes = append(changes, [2]*string{stringPtr(key), &hexValue}) lastValue[j] = &hexValue }

I know that having a string pointer is strange, but I did this so that the results for nil values show as JSON null.
Here is example output from polkadot v0.9.19 dev chain:

[ "0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", null ]

when I change and test gossamer (with runtime 0.9.19) with above changes I get output:

[ "0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", "" ],

however when hexValue in a string pointer I get the same results as the polkadot node.

Let me know if there is a different way to handle this so that the JSON parser treats nil values as null since I'd like to keep the output consistent with polkadot's output.

removed test genesis spec chain/dev/dev-spec-raw_gssmr9190.json

I know that having a string pointer is strange, but I did this so that the results for nil values show as JSON null. Here is example output from polkadot v0.9.19 dev chain:

[ "0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", null ]

when I change and test gossamer (with runtime 0.9.19) with above changes I get output:

[ "0x1cb6f36e027abb2091cfb5110ab5087f06155b3cd9a8c9e5e9a23fd5dc13a5ed", "" ],

however when hexValue in a string pointer I get the same results as the polkadot node.

Let me know if there is a different way to handle this so that the JSON parser treats nil values as null since I'd like to keep the output consistent with polkadot's output.

Oh i see. Yea it's a little awkward, but I see why you did that now.

Although thinking about this, the empty string should be synonym with null right? (at least conceptually)
Why are they returning null? I guess we can just ignore this and return null too.

timwu20

small change

dot/rpc/modules/state.go

timwu20 · 2022-07-07T15:08:31Z

Looks like there are some issues with this branch. It won't compile.

dot/rpc/modules/errors.go

dot/rpc/modules/state.go

qdm12 · 2022-07-13T21:58:52Z

tests/polkadotjs_test/test/test-polkadot.js

+                expect(item[0]).to.have.lengthOf(32);
+                expect(item[1]).to.have.lengthOf(2);


Can these be predicted or not? 🤔

no, the value seems to be random.

Do you think you could regex check them? Just to be sure we don't return i.e. empty strings (especially for future code changes).

tests/polkadotjs_test/test/test-polkadot.js

qdm12

Reviewed tests 😉

dot/rpc/modules/state_integration_test.go

dot/rpc/modules/state_test.go

qdm12 · 2022-07-15T15:25:20Z

tests/polkadotjs_test/test/test-polkadot.js

+                expect(item[0]).to.have.lengthOf(32);
+                expect(item[1]).to.have.lengthOf(2);


Do you think you could regex check them? Just to be sure we don't return i.e. empty strings (especially for future code changes).

chain/dev/config.toml

dot/rpc/modules/state.go

# [0.7.0](v0.6.0...v0.7.0) (2022-11-23) ### Bug Fixes * **chain:** update ed25519 addresses in dev/gssmr genesis files ([#2225](#2225)) ([5f47d8b](5f47d8b)) * **ci:** caching of Go caches ([#2451](#2451)) ([ce3c10c](ce3c10c)) * **ci:** codecov.yml configuration ([#2698](#2698)) ([d4fc383](d4fc383)) * **ci:** comment skip code for required workflows ([#2312](#2312)) ([45dce9b](45dce9b)) * **ci:** copyright workflow to exit if different files ([#2487](#2487)) ([89c32ae](89c32ae)) * **ci:** deepsource toml configuration ([#2744](#2744)) ([86a70de](86a70de)) * **ci:** embed v0.9.20 runtime, update test suite, and ci workflows ([#2543](#2543)) ([0fff418](0fff418)), closes [#2419](#2419) [#2561](#2561) [#2572](#2572) [#2581](#2581) [#2671](#2671) * **ci:** fix staging Dockerfile ([#2474](#2474)) ([ae04b80](ae04b80)) * **ci:** mocks checking fixes ([#2274](#2274)) ([d1308e0](d1308e0)) * **ci:** run devnet module unit tests ([#2756](#2756)) ([f635c59](f635c59)) * **ci:** run golangci-lint on integration tests ([#2275](#2275)) ([3ae3401](3ae3401)) * **cmd:** allow --genesis flag to be passed to base command ([#2427](#2427)) ([7f5b5aa](7f5b5aa)) * **cmd:** avoid nil pointer dereference ([#2578](#2578)) ([f2cdfea](f2cdfea)) * **config:** temporary fix for pprof enabled setting precedence ([#2786](#2786)) ([d4d6262](d4d6262)) * **core:** fix txn pool for latest runtime ([#2809](#2809)) ([1551e66](1551e66)) * **deps:** upgrade chaindb to remove badger logs ([#2738](#2738)) ([e0c5706](e0c5706)) * **devnet:** Fix build workflow for devnet ([#2125](#2125)) ([0375fc2](0375fc2)) * **Dockerfile:** remove script entrypoint ([#2707](#2707)) ([abd161b](abd161b)) * **dot/core:** `RuntimeInstance` interface `Version` signature ([#2783](#2783)) ([7d66ec0](7d66ec0)) * **dot/core:** fix the race condition in TrieState ([#2499](#2499)) ([804069c](804069c)), closes [#2402](#2402) * **dot/digest:** BABE NextEpochData and NextConfigData should be set on finalization ([#2339](#2339)) ([e991cc8](e991cc8)) * **dot/digest:** verify if next epoch already contains some definition ([#2472](#2472)) ([a2ac6c2](a2ac6c2)) * **dot/netwok:** check for duplicate message earlier ([#2435](#2435)) ([d62503f](d62503f)) * **dot/network:** change BlockRequestMessage number from uint64 to uint32 ([8105cd4](8105cd4)) * **dot/network:** close notifications streams ([#2093](#2093)) ([de6e7c9](de6e7c9)), closes [#2046](#2046) * **dot/network:** fixing errMissingHandshakeMutex ([#2303](#2303)) ([eb07a53](eb07a53)) * **dot/network:** memory improvement for network buffers ([#2233](#2233)) ([fd9b70d](fd9b70d)) * **dot/network:** public IP address logging ([#2140](#2140)) ([9e21587](9e21587)) * **dot/network:** re-add nil mutex check for disconnected peer ([#2408](#2408)) ([9b39bd1](9b39bd1)) * **dot/network:** remove `defer cancel()` inside loop ([#2248](#2248)) ([9e360a5](9e360a5)) * **dot/network:** resize bytes slice buffer if needed ([#2291](#2291)) ([8db8b2a](8db8b2a)) * **dot/peerset:** fix sending on closed channel race condition when dropping peer ([#2573](#2573)) ([2fa5d8a](2fa5d8a)) * **dot/peerset:** remove race conditions from `peerset` package ([#2267](#2267)) ([df09d45](df09d45)) * **dot/rpc/modules:** grandpa.proveFinality update parameters, fix bug ([#2576](#2576)) ([e7749cf](e7749cf)) * **dot/rpc/modules:** rpc.state.queryStorage fixed ([#2565](#2565)) ([1ec0d47](1ec0d47)) * **dot/rpc:** include unsafe flags to be considered by RPC layer ([#2483](#2483)) ([3822257](3822257)) * **dot/state/epoch, lib/babe:** enable block production through epochs without rely on finalization ([#2593](#2593)) ([a0a1804](a0a1804)) * **dot/state:** actually prune finalized tries from memory ([#2196](#2196)) ([e4bc375](e4bc375)) * **dot/state:** change map of tries implementation to have working garbage collection ([#2206](#2206)) ([fada46b](fada46b)) * **dot/state:** inject mutex protected tries to states ([#2287](#2287)) ([67a9bbb](67a9bbb)) * **dot/subscription:** check websocket message from untrusted data ([#2527](#2527)) ([1f20d98](1f20d98)) * **dot/subscription:** unsafe type casting from untrusted input ([#2529](#2529)) ([1015733](1015733)) * **dot/sync, dot/rpc:** implement HighestBlock ([#2195](#2195)) ([f8d8657](f8d8657)) * **dot/sync:** cleanup logs; don't log case where we fail to get parent while processing ([#2188](#2188)) ([cb360ab](cb360ab)) * **dot/sync:** fix "block with unknown header is ready" error ([#2191](#2191)) ([483466f](483466f)) * **dot/sync:** fix `Test_lockQueue_threadSafety` ([#2605](#2605)) ([223cfbb](223cfbb)) * **dot/sync:** Fix flaky tests `Test_chainSync_logSyncSpeed` and `Test_chainSync_start` ([#2610](#2610)) ([7e1014b](7e1014b)) * **dot/sync:** Gossip `BlockAnnounceMessage` only after successfully imported ([#2885](#2885)) ([69031a6](69031a6)) * **dot/sync:** remove block announcement in `bootstrap` sync mode ([#2906](#2906)) ([2b4c257](2b4c257)) * **dot/sync:** remove max size limit from ascending block requests ([#2256](#2256)) ([e287d7e](e287d7e)) * **dot/sync:** sync benchmark ([#2234](#2234)) ([2f3aef8](2f3aef8)) * **dot/telemetry:** telemetry hashes to be in the hexadecimal format ([#2194](#2194)) ([9b48106](9b48106)) * **dot:** database close error checks ([#2948](#2948)) ([bdb0eea](bdb0eea)) * **dot:** no error logged for init check ([#2502](#2502)) ([2971325](2971325)) * ensure we convert the `uint` type ([#2626](#2626)) ([792e53f](792e53f)) * fix logger mutex locking in `.New` method ([#2114](#2114)) ([e7207ed](e7207ed)) * **internal/log:** log level `DoNotChange` ([#2672](#2672)) ([0008b59](0008b59)) * **levels-logged:** Fix log levels logging at start ([#2236](#2236)) ([a90a6e0](a90a6e0)) * **lib/babe:** check if authority index is in the `authorities` range ([#2601](#2601)) ([1072888](1072888)) * **lib/babe:** ensure the slot time is correct before build a block ([#2648](#2648)) ([78c03b6](78c03b6)) * **lib/babe:** epoch context error wrapping ([#2484](#2484)) ([c053dea](c053dea)) * **lib/babe:** Unrestricted Loop When Building Blocks (GSR-19) ([#2632](#2632)) ([139ad89](139ad89)) * **lib/blocktree:** reimplement `BestBlockHash` to take into account primary blocks in fork choice rule ([#2254](#2254)) ([1a368e2](1a368e2)) * **lib/grandpa:** avoid spamming round messages ([#2688](#2688)) ([b0042b8](b0042b8)) * **lib/grandpa:** capped number of tracked commit messages ([#2490](#2490)) ([47c23e6](47c23e6)) * **lib/grandpa:** capped number of tracked vote messages ([#2485](#2485)) ([d2ee47e](d2ee47e)), closes [#1531](#1531) * **lib/grandpa:** check equivocatory votes count ([#2497](#2497)) ([014629d](014629d)), closes [#2401](#2401) * **lib/grandpa:** Duplicate votes is GRANDPA are counted as equivocatory votes (GSR-11) ([#2624](#2624)) ([422e7b3](422e7b3)) * **lib/grandpa:** Storing Justification Allows Extra Bytes (GSR-13) ([#2618](#2618)) ([0fcde63](0fcde63)) * **lib/grandpa:** update grandpa protocol ID ([#2678](#2678)) ([3be75b2](3be75b2)) * **lib/grandpa:** various finality fixes, improves cross-client finality ([#2368](#2368)) ([c04d185](c04d185)) * **lib/grandpa:** verify equivocatory votes in grandpa justifications ([#2486](#2486)) ([368f8b6](368f8b6)) * **lib/runtime:** avoid caching version in runtime instance ([#2425](#2425)) ([7ab31f0](7ab31f0)) * **lib/runtime:** stub v0.9.17 host API functions ([#2420](#2420)) ([6a7b223](6a7b223)) * **lib/trie:** `handleDeletion` generation propagation ([24c303d](24c303d)) * **lib/trie:** `PopulateMerkleValues` functionality changes and fixes ([#2871](#2871)) ([7131290](7131290)) * **lib/trie:** Check for root in EncodeAndHash ([#2359](#2359)) ([087db89](087db89)) * **lib/trie:** Make sure writing and reading a trie to disk gives the same trie and cover more store/load child trie related test cases ([#2302](#2302)) ([7cd4118](7cd4118)) * **lib/trie:** prepare trie nodes for mutation only when needed ([#2834](#2834)) ([26868df](26868df)) * **lib/trie:** remove map deletion at `loadProof` ([#2259](#2259)) ([fbd13d2](fbd13d2)) * **lint:** fix issues found by golangcilint 1.47.3 ([#2715](#2715)) ([5765e67](5765e67)) * **mocks:** add missing `//go:generate` for mocks ([#2273](#2273)) ([f4f7465](f4f7465)) * **pprof:** pprofserver flag changed to boolean ([#2205](#2205)) ([be00a69](be00a69)) * **staging:** revise datadog-agent start process ([#2935](#2935)) ([36ce37d](36ce37d)) * **state/epoch:** assign epoch 1 when block number is 0 ([#2592](#2592)) ([e5c8cf5](e5c8cf5)) * **state/grandpa:** track changes across forks ([#2519](#2519)) ([3ab76bc](3ab76bc)) * **tests:** `TestAuthorModule_HasSessionKeys_Integration` ([#2932](#2932)) ([8d809aa](8d809aa)) * **tests:** fix block body regex in `TestChainRPC` ([#2805](#2805)) ([b0680f8](b0680f8)) * **tests:** Fix RFC3339 regex for log unit tests ([9caea2a](9caea2a)) * **tests:** Fix wasmer flaky sorts ([#2643](#2643)) ([7eede9a](7eede9a)) * **tests:** handle node crash during waiting ([#2691](#2691)) ([843bd50](843bd50)) * **tests:** update block body regex in `TestChainRPC` ([#2674](#2674)) ([055e5c3](055e5c3)) * **trie:** decode inline child nodes ([#2369](#2369)) ([9efde47](9efde47)) * **trie:** descendants count for clear prefix ([#2606](#2606)) ([1826896](1826896)) * **trie:** disallow empty byte slice node values ([#2927](#2927)) ([d769d1c](d769d1c)) * **trie:** equality differentiate nil and empty storage values ([#2969](#2969)) ([72a08ec](72a08ec)) * **trie:** no in-memory caching of node encoding ([#2919](#2919)) ([856780b](856780b)) * **trie:** Panic when deleting nonexistent keys from trie (GSR-10) ([#2609](#2609)) ([7886318](7886318)) * **trie:** remove encoding buffers pool ([#2929](#2929)) ([f4074cc](f4074cc)) * **trie:** use cached Merkle values for root hash ([#2943](#2943)) ([ec2549a](ec2549a)) * **trie:** use direct Merkle value for database keys ([#2725](#2725)) ([1a3c3ae](1a3c3ae)) * upgrade auto-generated mocks ([#2910](#2910)) ([a2975a5](a2975a5)) * **wasmer:** error logs for signature verification ([#2752](#2752)) ([363c080](363c080)) * **wasmer:** fix flaky sort in `Test_ext_crypto_sr25519_public_keys_version_1` ([#2607](#2607)) ([c061b35](c061b35)) ### Features * **build:** add `github.com/breml/rootcerts` ([#2695](#2695)) ([c74a5b0](c74a5b0)) * **build:** binary built-in timezone data ([#2697](#2697)) ([fdd5bda](fdd5bda)) * **chain:** use always the raw genesis file ([#2775](#2775)) ([dd2fbc9](dd2fbc9)) * **ci:** update mockery from `2.10` to `2.14` ([#2642](#2642)) ([d2c42b8](d2c42b8)) * **cross-client:** create docker-compose.yml for local devnet ([#2282](#2282)) ([8abbd87](8abbd87)) * detect chain directory dynamically ([#2292](#2292)) ([85c466c](85c466c)) * **devnet:** add substrate docker images to dockerfile ([#2263](#2263)) ([b7b2a66](b7b2a66)) * **devnet:** continuous integration `gssmr` devnet on AWS ECS ([#2096](#2096)) ([d096d44](d096d44)) * **docker:** docker-compose.yml to run Gossamer, Prometheus and Grafana ([#2706](#2706)) ([c5dda51](c5dda51)) * **dot/network:** add mismatched genesis peer reporting ([#2265](#2265)) ([a1d7269](a1d7269)) * **dot/state:** `gossamer_storage_tries_cached_total` gauge metric ([#2272](#2272)) ([625cbcf](625cbcf)) * **e2e:** build Gossamer on any test run ([#2608](#2608)) ([f97e0ef](f97e0ef)) * **go:** upgrade Go from 1.17 to 1.18 ([#2379](#2379)) ([d85a1db](d85a1db)) * include nested varying data type on neighbor messages ([#2722](#2722)) ([426569a](426569a)) * **lib/babe:** implement secondary slot block production ([#2260](#2260)) ([fcb81a3](fcb81a3)) * **lib/runtime:** support Substrate WASM compression ([#2213](#2213)) ([fd60061](fd60061)) * **lib/trie:** atomic tracked merkle values ([#2876](#2876)) ([1c4174c](1c4174c)) * **lib/trie:** clear fields when node is dirty ([#2297](#2297)) ([1162828](1162828)) * **lib/trie:** only copy nodes when mutation is certain ([#2352](#2352)) ([86624cf](86624cf)) * **lib/trie:** opportunistic parallel hashing ([#2081](#2081)) ([790dfb5](790dfb5)) * **metrics:** replace metrics port with address (breaking change) ([#2382](#2382)) ([d2ec68d](d2ec68d)) * **pkg/scale:** add `Encoder` with `Encode` method ([#2741](#2741)) ([af5c63f](af5c63f)) * **pkg/scale:** add use of pkg/error Wrap for error handling ([#2708](#2708)) ([08c4281](08c4281)) * **pkg/scale:** encoding and decoding of maps in scale ([#2894](#2894)) ([405db51](405db51)), closes [#2796](#2796) * **pkg/scale:** support for custom `VaryingDataType` types ([#2612](#2612)) ([914a747](914a747)) * remove uneeded runtime prefix logs ([#2110](#2110)) ([8bd05d1](8bd05d1)) * remove unused code ([#2677](#2677)) ([b3698d7](b3698d7)) * **scale:** add range checks to decodeUint function ([#2683](#2683)) ([ac700f8](ac700f8)) * **trie:** decode all inlined node variants ([#2611](#2611)) ([b09eb07](b09eb07)) * **trie:** export `LoadFromProof` ([#2455](#2455)) ([0b4f33d](0b4f33d)) * **trie:** faster header decoding ([#2649](#2649)) ([d9460e3](d9460e3)) * **trie:** finer deep copy of nodes ([#2384](#2384)) ([bd6d8e4](bd6d8e4)) * **trie:** tracking of number of descendant nodes for each node ([#2378](#2378)) ([dfcdd3c](dfcdd3c)) * **trie:** use scale encoder ([#2930](#2930)) ([e3dc108](e3dc108)) * **wasmer/crypto:** move sig verifier to crypto pkg ([#2057](#2057)) ([dc8bbef](dc8bbef)) * **wasmer:** Add `SetTestVersion` method to `Config` struct ([#2823](#2823)) ([e5c9336](e5c9336)) * **wasmer:** get and cache state version in instance context ([#2747](#2747)) ([3fd63db](3fd63db))

github-actions · 2022-11-23T18:30:05Z

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

edwardmack requested review from noot, timwu20, EclesioMeloJunior, jimjbrettj, kishansagathiya and qdm12 as code owners May 20, 2022 19:25

edwardmack self-assigned this May 20, 2022

edwardmack marked this pull request as draft May 20, 2022 19:48

edwardmack marked this pull request as ready for review May 25, 2022 19:53

qdm12 reviewed Jun 3, 2022

View reviewed changes

edwardmack requested a review from qdm12 June 14, 2022 20:58

edwardmack added 18 commits June 15, 2022 11:03

setup files for testing with rt 0.9.19

1bf8834

add to tests

a9fd5ca

implement rpc_state_queryStorage

0f1745a

WIP creating TestStateModuleQueryStorage

996cd0a

remove unused functions, lint

10ad1ee

change tests mocks

89e6751

implement unit tests

db547bc

fix failing tests

4a4bb34

fix integration tests

821d00d

revert config.toml to use original genesis-spec.json

a3a47ee

fix lint issues

ee1988c

regen mockery files

ea34a13

regerate mockery files

bd5156a

edit config.toml, remove comments

2fdf270

create file for mockgen

3298176

address PR comments

3bf9b5a

add to unit tests

64cd32f

add tests to mocha tests

140c534

address lint issue

2c3678e

timwu20 reviewed Jun 29, 2022

View reviewed changes

timwu20 requested changes Jun 29, 2022

View reviewed changes

remove test genesis spec file

2ca4586

edwardmack requested review from timwu20 and qdm12 June 29, 2022 18:50

edwardmack added 3 commits July 1, 2022 15:37

Merge branch 'development' into ed/rpc_state_queryStorage

9ebcc8b

fix merge conflicts

b41a0a0

Merge branch 'development' into ed/rpc_state_queryStorage

f5f51d8

timwu20 requested changes Jul 7, 2022

View reviewed changes

dot/rpc/modules/state.go Outdated Show resolved Hide resolved

use stringPtr for assignment, re-run mockery generation

bcd11fd

edwardmack requested a review from timwu20 July 8, 2022 15:18

timwu20 approved these changes Jul 8, 2022

View reviewed changes

qdm12 reviewed Jul 13, 2022

View reviewed changes

qdm12 reviewed Jul 14, 2022

View reviewed changes

edwardmack added 5 commits July 14, 2022 14:42

use regexp to test for errors

7f0344d

address PR comments for state_test

4f79e2e

address comments regarding test-polkadot.js

fad98c8

address PR comments

d028e39

add copyright notice

f10020f

edwardmack requested a review from qdm12 July 15, 2022 14:21

qdm12 approved these changes Jul 15, 2022

View reviewed changes

EclesioMeloJunior approved these changes Jul 15, 2022

View reviewed changes

chain/dev/config.toml Outdated Show resolved Hide resolved

chain/dev/config.toml Outdated Show resolved Hide resolved

dot/rpc/modules/state.go Outdated Show resolved Hide resolved

edwardmack added 2 commits July 19, 2022 11:21

add check for hex string

aaf8fa4

remove firstPass variable

dd41f16

edwardmack merged commit 1ec0d47 into development Jul 19, 2022

edwardmack deleted the ed/rpc_state_queryStorage branch July 19, 2022 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dot/rpc/modules): rpc.state.queryStorage fixed #2565

fix(dot/rpc/modules): rpc.state.queryStorage fixed #2565

edwardmack commented May 20, 2022

codecov bot commented May 25, 2022 •

edited

Loading

timwu20 left a comment

timwu20 left a comment

timwu20 Jun 29, 2022

edwardmack Jun 29, 2022

edwardmack Jun 29, 2022

timwu20 Jul 7, 2022

qdm12 Jul 15, 2022

timwu20 left a comment

timwu20 commented Jul 7, 2022

qdm12 Jul 13, 2022

edwardmack Jul 14, 2022

qdm12 Jul 15, 2022

qdm12 left a comment

qdm12 Jul 15, 2022

github-actions bot commented Nov 23, 2022

		expect(item[0]).to.have.lengthOf(32);
		expect(item[1]).to.have.lengthOf(2);

fix(dot/rpc/modules): rpc.state.queryStorage fixed #2565

fix(dot/rpc/modules): rpc.state.queryStorage fixed #2565

Conversation

edwardmack commented May 20, 2022

Changes

Tests

Issues

Primary Reviewer

codecov bot commented May 25, 2022 • edited Loading

Codecov Report

timwu20 left a comment

Choose a reason for hiding this comment

timwu20 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timwu20 left a comment

Choose a reason for hiding this comment

timwu20 commented Jul 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qdm12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 23, 2022

codecov bot commented May 25, 2022 •

edited

Loading