Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of .construct() method #68

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Remove usage of .construct() method #68

merged 13 commits into from
Mar 3, 2022

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Mar 3, 2022

Fixes #67
Closes #66

@CasperWA
Allow using local oteapi-core repository
c2bacb1 
This is only available for the `development` Dockerfile target.
@CasperWA
Remove usage of the construct() method
6756e1f 
The `construct()` method of pydantic models doesn't actually "cast" the
input values to the desired attribute types, e.g., not converting a
string to a URL type - this is very undesired.
@CasperWA
Document new PATH_TO_OTEAPI_CORE env var
f6ca3ed
@CasperWA CasperWA added the BLOCKING This issue or PR blocks further development label Mar 3, 2022
@CasperWA CasperWA mentioned this pull request Mar 3, 2022
Merged
@CasperWA CasperWA enabled auto-merge (squash) March 3, 2022 10:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #68 (83de88a) into master (8606752) will not change coverage.
The diff coverage is 53.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          15       15           
  Lines         414      414           
=======================================
  Hits          282      282           
  Misses        132      132
Flag Coverage Δ
pytest 68.11% <53.84%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/routers/dataresource.py 28.35% <0.00%> (ø)
app/routers/session.py 50.00% <0.00%> (ø)
app/routers/transformation.py 68.18% <75.00%> (ø)
app/routers/datafilter.py 80.43% <100.00%> (ø)
app/routers/mapping.py 80.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8606752...83de88a. Read the comment docs.

@CasperWA
Ensure PATH_TO_OTEAPI_CORE works for docker call
e12cf12 
A default is set through the docker-compose_dev.yml file, however if not
using docker compose, but straightup docker, this will fail currently.

Adds a check to see whether PATH_TO_OTEAPI_CORE even exists/is empty or
not.
@CasperWA
Try to fix PATH_TO_OTEAPI_CORE env variable in CI
83de88a
@CasperWA CasperWA disabled auto-merge March 3, 2022 10:31
@CasperWA CasperWA enabled auto-merge (squash) March 3, 2022 11:02
@CasperWA CasperWA merged commit b1886f6 into master Mar 3, 2022
@CasperWA CasperWA deleted the cwa/fix-67-66-construct-method-development-setup branch March 3, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesper-friis jesper-friis jesper-friis approved these changes

Assignees
No one assigned
Labels
BLOCKING This issue or PR blocks further development
Projects
None yet
Milestone
No milestone
3 participants
@CasperWA @codecov-commenter @jesper-friis