Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of .construct() method #68

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Remove usage of .construct() method #68

merged 13 commits into from
Mar 3, 2022

Commits on Mar 3, 2022

  1. Allow using local oteapi-core repository 

    This is only available for the `development` Dockerfile target.
    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    c2bacb1 View commit details
    Browse the repository at this point in the history

  2. Remove usage of the construct() method 

    The `construct()` method of pydantic models doesn't actually "cast" the
input values to the desired attribute types, e.g., not converting a
string to a URL type - this is very undesired.
    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    6756e1f View commit details
    Browse the repository at this point in the history

  3. Document new PATH_TO_OTEAPI_CORE env var

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    f6ca3ed View commit details
    Browse the repository at this point in the history

  4. Instantiate a default value for PATH_TO_OTEAPI_CORE

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    6301b49 View commit details
    Browse the repository at this point in the history

  5. Supply default value to PATH_TO_OTEAPI_CORE 

    Test PATH_TO_OTEAPI_CORE in CI.
    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    093f051 View commit details
    Browse the repository at this point in the history

  6. Quick fix for wrong CI variable

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    f76d3bf View commit details
    Browse the repository at this point in the history

  7. Ensure PATH_TO_OTEAPI_CORE works for docker call 

    A default is set through the docker-compose_dev.yml file, however if not
using docker compose, but straightup docker, this will fail currently.

Adds a check to see whether PATH_TO_OTEAPI_CORE even exists/is empty or
not.
    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    e12cf12 View commit details
    Browse the repository at this point in the history

  8. Try to fix PATH_TO_OTEAPI_CORE env variable in CI

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    83de88a View commit details
    Browse the repository at this point in the history

  9. Try to first down the currently running docker-compose

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    c070137 View commit details
    Browse the repository at this point in the history

  10. Extend sleep time

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    35e4a02 View commit details
    Browse the repository at this point in the history

  11. Try to use -d instead of &

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    0754c1a View commit details
    Browse the repository at this point in the history

  12. Return sleep commands

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    85295dc View commit details
    Browse the repository at this point in the history

  13. Return & to try to see output

    @CasperWA
    CasperWA committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    912dcfe View commit details
    Browse the repository at this point in the history